Skip to content

core: fix the issue that BatchScanRegions is not limited #9215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2025
Merged

core: fix the issue that BatchScanRegions is not limited #9215

merged 2 commits into from
Apr 18, 2025

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Apr 17, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #9216

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024
core: fix the issue that BatchScanRegions is not limited
8810cf8 
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.93%. Comparing base (748d6c8) to head (52b58a7).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9215      +/-   ##
==========================================
- Coverage   75.97%   75.93%   -0.04%     
==========================================
  Files         471      471              
  Lines       73167    73171       +4     
==========================================
- Hits        55586    55566      -20     
- Misses      14119    14145      +26     
+ Partials     3462     3460       -2
Flag Coverage Δ
unittests 75.93% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 18, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 18, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-18 03:25:37.784397532 +0000 UTC m=+3004431.468633622: ☑️ agreed by rleungx.
  • 2025-04-18 03:29:45.007632207 +0000 UTC m=+3004678.691868303: ☑️ agreed by okJiang.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Apr 18, 2025

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot merged commit ba2536d into tikv:master Apr 18, 2025
35 of 36 checks passed
@lhy1024 lhy1024 deleted the fix-limit2 branch April 18, 2025 06:41
@lhy1024
Copy link
Contributor Author

lhy1024 commented Apr 18, 2025

/cherry-pick release-8.5

@lhy1024 lhy1024 added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Apr 18, 2025
@ti-chi-bot
Copy link
Member

@lhy1024: new pull request created to branch release-8.5: #9218.
But this PR has conflicts, please resolve them!

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Apr 18, 2025
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#9215
056e36c 
close tikv#9216

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 18, 2025
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against tikv/pd#release-8.5 from head ti-chi-bot:cherry-pick-9215-to-release-8.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-9215-to-release-8.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Apr 18, 2025
@lhy1024 @ti-chi-bot
This is an automated cherry-pick of tikv#9215
00297eb 
close tikv#9216

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 21, 2025
@ti-chi-bot @lhy1024
core: fix the issue that BatchScanRegions is not limited (#9215) (#9218)
064ddd6 
close #9216

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: lhy1024 <liuhanyang@pingcap.com>
Co-authored-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

+1 more reviewer

@okJiang okJiang okJiang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BatchScanRegions is not limited
4 participants
@lhy1024 @ti-chi-bot @okJiang @rleungx