Skip to content

keypath: fix incorrect key (#9133) #9136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2025
Merged

keypath: fix incorrect key (#9133) #9136

merged 4 commits into from
Mar 13, 2025

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9133

What problem does this PR solve?

Issue Number: Close #9132

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

ref #9131

Release note

None.

okJiang added 2 commits March 12, 2025 10:29
@okJiang @ti-chi-bot
fix registry/prefix/safe_point/scheduler_config key
6392204 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang @ti-chi-bot
fix comment
961b684 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1 labels Mar 12, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 12, 2025
Merged
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. labels Mar 12, 2025
@okJiang
Copy link
Member

okJiang commented Mar 13, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 13, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 13, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 13, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-12 10:30:18.582015932 +0000 UTC m=+351774.187544844: ☑️ agreed by okJiang.
  • 2025-03-13 03:06:42.860673184 +0000 UTC m=+411558.466202110: ☑️ agreed by lhy1024.

@okJiang
Copy link
Member

okJiang commented Mar 13, 2025

/retest

okJiang added 2 commits March 13, 2025 11:26
@okJiang
update workflow trigger
7152fb1 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
update tso trigger
eab2ac2 
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-9.0-beta.1@e245c1f). Learn more about missing BASE report.

Additional details and impacted files 
@@                  Coverage Diff                  @@
##             release-9.0-beta.1    #9136   +/-   ##
=====================================================
  Coverage                      ?   76.28%           
=====================================================
  Files                         ?      473           
  Lines                         ?    71981           
  Branches                      ?        0           
=====================================================
  Hits                          ?    54908           
  Misses                        ?    13628           
  Partials                      ?     3445
Flag Coverage Δ
unittests 76.28% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot merged commit 159fe3b into tikv:release-9.0-beta.1 Mar 13, 2025
22 checks passed
@okJiang okJiang deleted the cherry-pick-9133-to-release-9.0-beta.1 branch March 13, 2025 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

+1 more reviewer

@okJiang okJiang okJiang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@okJiang okJiang

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @okJiang @lhy1024