Skip to content

server: advance ServerStart check (#8951) #8971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

server: advance ServerStart check (#8951) #8971

merged 1 commit into from
Jan 6, 2025

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8951

What problem does this PR solve?

Issue Number: Close #8950

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Fix the problem that PD may panic after enable `tidb_enable_tso_follower_proxy`.

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jan 3, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 3, 2025
Merged
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2025
@okJiang
fix
f8e3a1f 
Signed-off-by: okJiang <819421878@qq.com>
@okJiang okJiang force-pushed the cherry-pick-8951-to-release-8.5 branch from 9eb5fb6 to f8e3a1f Compare January 3, 2025 08:37
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 3, 2025
@okJiang
Copy link
Member

okJiang commented Jan 3, 2025

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 3, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.54%. Comparing base (98df926) to head (f8e3a1f).
Report is 1 commits behind head on release-8.5.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-8.5    #8971      +/-   ##
===============================================
+ Coverage        75.53%   75.54%   +0.01%     
===============================================
  Files              462      462              
  Lines            72355    72360       +5     
===============================================
+ Hits             54650    54663      +13     
+ Misses           14194    14189       -5     
+ Partials          3511     3508       -3
Flag Coverage Δ
unittests 75.54% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 6, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 6, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-03 08:46:54.285954833 +0000 UTC m=+685749.641959373: ☑️ agreed by okJiang.
  • 2025-01-06 03:23:57.376411917 +0000 UTC m=+151180.665243627: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit d62b7b6 into tikv:release-8.5 Jan 6, 2025
20 of 22 checks passed
okJiang added a commit to okJiang/pd that referenced this pull request Mar 10, 2025
@ti-chi-bot @okJiang
server: advance ServerStart check (tikv#8951) (tikv#8971)
dc754aa 
close tikv#8950

Signed-off-by: okJiang <819421878@qq.com>

Co-authored-by: okJiang <819421878@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

+1 more reviewer

@okJiang okJiang okJiang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@okJiang okJiang

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @okJiang @lhy1024