Skip to content

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 5, 2024

What problem does this PR solve?

Issue Number: ref #8823.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2024
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.19%. Comparing base (29dfaf9) to head (d04c54c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8873      +/-   ##
==========================================
+ Coverage   76.14%   76.19%   +0.04%     
==========================================
  Files         458      459       +1     
  Lines       70208    70239      +31     
==========================================
+ Hits        53462    53519      +57     
+ Misses      13389    13364      -25     
+ Partials     3357     3356       -1     
Flag Coverage Δ
unittests 76.19% <84.61%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 6, 2024
@rleungx rleungx removed needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Dec 6, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-06 03:08:00.998266225 +0000 UTC m=+1383468.617920740: ☑️ agreed by lhy1024.
  • 2024-12-06 04:08:46.351621022 +0000 UTC m=+1387113.971275535: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 53adbed into tikv:master Dec 6, 2024
25 checks passed
@rleungx rleungx deleted the test-syncer branch December 6, 2024 04:29
rleungx added a commit to ti-chi-bot/pd that referenced this pull request Dec 6, 2024
ref tikv#8823

Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx added a commit to rleungx/pd that referenced this pull request Dec 6, 2024
ref tikv#8823

Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 6, 2024
ref #8823

Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx added a commit to ti-chi-bot/pd that referenced this pull request Dec 11, 2024
ref tikv#8823

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants