Skip to content

mcs: solve forward stream error #7321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2023
Merged

mcs: solve forward stream error #7321

merged 3 commits into from
Nov 7, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Nov 6, 2023

What problem does this PR solve?

Issue Number: Close #7320

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024
mcs: solve forward stream error
07f806d 
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 requested review from JmPotato and rleungx November 6, 2023 03:18
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2023
@lhy1024
rebuild connect
71175e3 
Signed-off-by: lhy1024 <admin@liudos.us>
zeminzhou
zeminzhou reviewed Nov 6, 2023
View reviewed changes
server/grpc_service.go
err := forwardStream.Send(request)
if err != nil {
s.tsoClientPool.Lock()
delete(s.tsoClientPool.clients, forwardedHost)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do close？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. We need to avoid that there are always errors.

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited
Loading

Codecov Report

Merging #7321 (3c8eccb) into master (c332ddc) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7321      +/-   ##
==========================================
+ Coverage   74.38%   74.42%   +0.03%     
==========================================
  Files         446      446              
  Lines       48352    48357       +5     
==========================================
+ Hits        35969    35991      +22     
+ Misses       9198     9181      -17     
  Partials     3185     3185
Flag Coverage Δ
unittests 74.42% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 6, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 7, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 7, 2023

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 71175e3

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 7, 2023

/run-check-issue-triage-complete

@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 7, 2023

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Nov 7, 2023

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 7, 2023

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 356066a into tikv:master Nov 7, 2023
@lhy1024 lhy1024 deleted the fix-tso branch November 7, 2023 06:13
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
@lhy1024
mcs: solve forward stream error (tikv#7321)(tikv#7327) (tikv#223)
da04218 
* mcs: solve forward stream error (tikv#7321)

close tikv#7320

Signed-off-by: lhy1024 <admin@liudos.us>

* mcs: solve stream error when forward tso (tikv#7327)

close tikv#7320

Signed-off-by: lhy1024 <admin@liudos.us>

---------

Signed-off-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@rleungx rleungx rleungx approved these changes

+1 more reviewer

@zeminzhou zeminzhou zeminzhou left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The error of forwarding TSO should be handled
4 participants
@lhy1024 @JmPotato @rleungx @zeminzhou