Skip to content

tests: make the TSO testing as independent as possible #6183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 21, 2023
Merged

tests: make the TSO testing as independent as possible #6183

merged 7 commits into from
Mar 21, 2023

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Mar 20, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6181.

What is changed and how does it work?

- Support testing both legacy and microservice TSO.
- Make the TSO testing as independent as possible.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added component/testing CI testing. component/tso Timestamp Oracle. labels Mar 20, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 20, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • binshi-bing
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 20, 2023
@ti-chi-bot ti-chi-bot requested a review from lhy1024 March 20, 2023 10:18
@codecov
Copy link

codecov bot commented Mar 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (832047e) 74.73% compared to head (c8c3555) 74.72%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6183      +/-   ##
==========================================
- Coverage   74.73%   74.72%   -0.01%     
==========================================
  Files         394      395       +1     
  Lines       38669    38677       +8     
==========================================
+ Hits        28898    28903       +5     
- Misses       7230     7237       +7     
+ Partials     2541     2537       -4
Flag Coverage Δ
unittests 74.72% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/client.go 62.46% <ø> (ø)
client/tso_client.go 77.45% <ø> (ø)
pkg/utils/testutil/testutil.go 100.00% <ø> (ø)
pkg/mcs/tso/server/testutil.go 88.88% <100.00%> (+2.22%) ⬆️
tests/tso/testutil.go 100.00% <100.00%> (ø)

... and 27 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JmPotato JmPotato marked this pull request as ready for review March 20, 2023 14:21
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2023
@JmPotato JmPotato requested a review from rleungx March 20, 2023 14:23
@JmPotato JmPotato changed the title tests: independent the TSO testing tests: make the TSO testing as independent as possible Mar 20, 2023
@JmPotato
Copy link
Member Author

/cc @binshi-bing @rleungx @lhy1024

PTAL

@ti-chi-bot
Copy link
Member

@JmPotato: GitHub didn't allow me to request PR reviews from the following users: binshi-bing.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @binshi-bing @rleungx @lhy1024

PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

binshi-bing
binshi-bing approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@binshi-bing binshi-bing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@binshi-bing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

rleungx
rleungx reviewed Mar 21, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 21, 2023
binshi-bing
binshi-bing approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@binshi-bing binshi-bing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first LGTM after I became the reviewer

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2023
JmPotato added 6 commits March 21, 2023 14:05
@JmPotato
Independent the TSO testing
979aa37 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Integrate more tests
e6f1c3c 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Address the comments
d6f5ecf 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Fix the incorrect context
354670a 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Fix the server closing hang
443b19c 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Fix TestZeroTSOCount
a272370 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Fix Makefile
c8c3555 
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c8c3555

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2023
@ti-chi-bot ti-chi-bot merged commit 2b0cbae into tikv:master Mar 21, 2023
@JmPotato JmPotato deleted the resort_tso_test branch March 21, 2023 06:16
@JmPotato JmPotato mentioned this pull request Mar 24, 2023
Merged
ti-chi-bot pushed a commit that referenced this pull request Mar 24, 2023
@JmPotato
tests: divide all tests into the CI chunks including submodule tests (#…
c3934e4 
…6198)

ref #6181, ref #6183

Divide all tests into the CI chunks including submodule tests.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@binshi-bing binshi-bing binshi-bing approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

Assignees
No one assigned
Labels
component/testing CI testing. component/tso Timestamp Oracle. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JmPotato @ti-chi-bot @rleungx @binshi-bing