Skip to content

*: fix election race #5573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2022
Merged

*: fix election race #5573

merged 2 commits into from
Oct 9, 2022

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Oct 9, 2022

Signed-off-by: Ryan Leung rleungx@gmail.com

What problem does this PR solve?

Issue Number: Close #5434.

What is changed and how does it work?

There is a probability that the ResetLeader can run at the same time as KeepLeader, which may cause a race.

Check List

Tests

  • Manual test

Release note

None

@rleungx
fix election race
f54906e 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 9, 2022
@rleungx rleungx marked this pull request as ready for review October 9, 2022 03:36
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 9, 2022
@rleungx rleungx requested review from nolouch and removed request for disksing October 9, 2022 03:41
@codecov
Copy link

codecov bot commented Oct 9, 2022 •
edited
Loading

Codecov Report

Base: 75.59% // Head: 75.78% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (e7caad7) compared to base (b326e4f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5573      +/-   ##
==========================================
+ Coverage   75.59%   75.78%   +0.18%     
==========================================
  Files         326      326              
  Lines       32255    32255              
==========================================
+ Hits        24383    24443      +60     
+ Misses       5758     5706      -52     
+ Partials     2114     2106       -8
Flag Coverage Δ
unittests 75.78% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/election/leadership.go 78.35% <100.00%> (+3.09%) ⬆️
server/server.go 75.44% <100.00%> (+0.37%) ⬆️
server/tso/tso.go 69.10% <0.00%> (-1.69%) ⬇️
server/region_syncer/client.go 85.82% <0.00%> (-0.75%) ⬇️
server/tso/allocator_manager.go 64.77% <0.00%> (-0.65%) ⬇️
server/cluster/cluster.go 83.12% <0.00%> (-0.27%) ⬇️
server/member/member.go 63.68% <0.00%> (ø)
server/storage/endpoint/meta.go 63.63% <0.00%> (ø)
server/schedulers/hot_region_v2.go 80.11% <0.00%> (+0.58%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 9, 2022
@rleungx
Copy link
Member Author

rleungx commented Oct 9, 2022

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f54906e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 9, 2022
@ti-chi-bot
Copy link
Member

@rleungx: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d1902f9 into tikv:master Oct 9, 2022
@rleungx rleungx deleted the fix-race8 branch October 9, 2022 07:27
@rleungx rleungx added the component/testing CI testing. label Oct 10, 2022
lhy1024 pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 28, 2023
@rleungx @ti-chi-bot @lhy1024
*: fix election race (tikv#5573)
0275cba 
close tikv#5434

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: lhy1024 <admin@liudos.us>
lhy1024 pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 28, 2023
@rleungx @ti-chi-bot @lhy1024
*: fix election race (tikv#5573)
f415707 
close tikv#5434

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: lhy1024 <admin@liudos.us>
lhy1024 pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 28, 2023
@rleungx @ti-chi-bot @lhy1024
*: fix election race (tikv#5573)
dbe5909 
close tikv#5434

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Signed-off-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
component/testing CI testing. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data race in election
4 participants
@rleungx @ti-chi-bot @JmPotato @nolouch