Wrap RGLObject into try-catch to avoid processing the same objects endlessly #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiotrMrozik
reviewed
Sep 19, 2023
Assets/RGLUnityPlugin/Scripts/LowLevelWrappers/RGLMeshObject.cs
Outdated
Show resolved
Hide resolved
Assets/RGLUnityPlugin/Scripts/LowLevelWrappers/RGLMeshObject.cs
Outdated
Show resolved
Hide resolved
PiotrMrozik
approved these changes
Sep 21, 2023
tzu-lin-huang
pushed a commit
to OptiVerse-Technology-Ltd/AWSIM
that referenced
this pull request
Aug 26, 2025
…atch Wrap RGLObject into try-catch to avoid processing the same objects endlessly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the issue, some of the game objects on the scene don't have mesh assigned to them, which prevents RGLObjects from being created on them (an exception is thrown in the constructor of RGLObject). It causes the current Update to abort and process the same objects on the next Update (and this situation repeats indefinitely).
This PR wraps RGLObject creation into a try-catch block which skips game objects from which no RGLObject can be created.