Skip to content

Conversation

Jakub-Krakowiak
Copy link
Contributor

Removed LINQ and lambdas from initialization of thisFrameGOs variable. Performance tested on AWSIM/Scenes/Samples/LidarSkinnedStress scene since it provides a stable number of entities. The performance of the "Find changes and make TODO list" profiler section improved drastically from taking 21 ms to 9 ms on my machine:

Lenovo Legion Laptop
Processor: 1x 10th Generation Intel® Core™ i7-10750H Processor(Core™ i7-10750H)
Graphics: 1x NVIDIA®GeForce RTX™2070 SUPER™

I tried removing LINQ and lambdas from all other parts of SceneManager.cs, but this offered no noticeable performance improvements, so I decided to keep the old code for readability reasons.

@Jakub-Krakowiak Jakub-Krakowiak changed the title Removed LINQ and lambdas from initialization of thisFrameGOs variable Performance increase for RGLUnityPlugin by reducing garbage collection Jul 9, 2023
@pijaro pijaro requested a review from mackierx111 July 10, 2023 09:39
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mackierx111 mackierx111 merged commit fdbb880 into tier4:main Jul 31, 2023
tyongingo pushed a commit to tyongingo/AWSIM that referenced this pull request Nov 22, 2024
Signed-off-by: A. Sena Yılmaz <aysena@leodrive.ai>
tzu-lin-huang pushed a commit to OptiVerse-Technology-Ltd/AWSIM that referenced this pull request Aug 26, 2025
…garbage-collection

Performance increase for RGLUnityPlugin by reducing garbage collection
tzu-lin-huang pushed a commit to OptiVerse-Technology-Ltd/AWSIM that referenced this pull request Aug 26, 2025
Signed-off-by: A. Sena Yılmaz <aysena@leodrive.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants