Skip to content

Conversation

lchojnack
Copy link
Contributor

Add possibility to set initial EGO position and rotation from JSON config file

Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
@WJaworskiRobotec
Copy link
Contributor

@lchojnack @mackierx111

One general comment: What do you think about keeping ego pose in the separate configuration instead of the than existing one with TimeScale, RandomTrafficSeed and MaxVehicleCount?

Keeping layers of configuration might be very comfortable for the future

@mackierx111
Copy link
Collaborator

@WJaworskiRobotec
Thanks for the comment. I can understand your point of view.

I think a good way at this point is to show users a simple sample like AutowareSimualtion.cs. I would like to merge this pull request first, and then improve it if a more detailed config design is needed.

Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mackierx111 mackierx111 merged commit f18a062 into main Aug 3, 2023
@mackierx111 mackierx111 deleted the feature/ego-initial-position-rotation-config branch August 3, 2023 08:03
tzu-lin-huang pushed a commit to OptiVerse-Technology-Ltd/AWSIM that referenced this pull request Aug 26, 2025
…rotation-config

Add ego initial position and rotation from json config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants