Catch I/O errors in sendContinuation() #9382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch IOException in sendContinuation() similar to the other send / receive methods. This fixes broken IMAP push on network loss/regain on the authors phone. Log that exception in sendDone(). Also reset read timeout after IDLE.
wmontwe
approved these changes
Jul 1, 2025
| Log.v("%s>>> %s", logId, continuation) | ||
| } | ||
| } catch (e: IOException) { | ||
| close() |
There was a problem hiding this comment.
Great, I guess not closing the connection was the issue.
|
Thanks for your contribution! Your pull request has been merged and will be part of Thunderbird 12. We appreciate the time and effort you put into improving Thunderbird. If you haven’t already, you’re welcome to join our Matrix chat for contributors. It’s where we discuss development and help each other out. https://matrix.to/#/#tb-android-dev:mozilla.org |
coreycb
pushed a commit
that referenced
this pull request
Jul 2, 2025
Catch I/O errors in sendContinuation()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch IOException in sendContinuation() similar to the other send / receive methods.
This fixes broken IMAP push on network loss/regain on the authors phone.
Log that exception in sendDone().
Also reset read timeout after IDLE.
This fixes broken IMAP IDLE on my phone (Pixel 6 Pro w/ Android 16). IMAP IDLE is reproducably broken if the home wifi is left for about an hour (mobile data on) then the phone returns. Unfortunately I have not been able to log the issue as the log's history is always way too short. But unpatched K-9 Mail this IMAP IDLE breaks every time; with this patch it so far has not broken (about 5 "events" were it should have and did break -- I was running both versions in parallel).