-
Notifications
You must be signed in to change notification settings - Fork 35
fix: optimize insertions in building when lists = 1 #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
VectorChord/docker/pgrx.Dockerfile Lines 48 to 54 in 0360d7c
CI fails. |
If you change the toolchain version, you may need to update the image. I'll create a CI to push the image to GitHub packages so developers can trigger the CI to update the image. |
Why do we need to update the image? Why not add targets when image is used? |
Adding targets later means you need to do it for every docker image run. Updating the version is not a highly frequent operation. |
I think adding a target takes less than one second on Github actions and downloading the docker image takes more than one. If we want it to be faster, we should remove docker for first. |
Adding targets costs about 17.8s in GitHub CI. Downloading the whole image is about 53s for now, almost the same as downloading from Docker Hub. |
No description provided.