Skip to content

Conversation

usamoi
Copy link
Contributor

@usamoi usamoi commented Nov 21, 2024

No description provided.

Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
Signed-off-by: usamoi <usamoi@outlook.com>
@usamoi
Copy link
Contributor Author

usamoi commented Nov 21, 2024

@kemingy

WORKDIR /workspace
COPY rust-toolchain.toml /workspace/rust-toolchain.toml
# ref: https://github.com/pgcentralfoundation/pgrx/blob/develop/docs/src/extension/build/cross-compile.md
RUN set -ex; \
echo 'target.aarch64-unknown-linux-gnu.linker = "aarch64-linux-gnu-gcc"' >> ~/.cargo/config.toml; \
echo 'target.aarch64-unknown-linux-gnu.runner = ["qemu-aarch64-static", "-L", "/usr/aarch64-linux-gnu"]' >> ~/.cargo/config.toml
RUN rustup target add x86_64-unknown-linux-gnu aarch64-unknown-linux-gnu

CI fails.

@kemingy
Copy link
Member

kemingy commented Nov 21, 2024

If you change the toolchain version, you may need to update the image. I'll create a CI to push the image to GitHub packages so developers can trigger the CI to update the image.

@usamoi
Copy link
Contributor Author

usamoi commented Nov 21, 2024

If you change the toolchain version, you may need to update the image. I'll create a CI to push the image to GitHub packages so developers can trigger the CI to update the image.

Why do we need to update the image? Why not add targets when image is used?

@kemingy
Copy link
Member

kemingy commented Nov 21, 2024

If you change the toolchain version, you may need to update the image. I'll create a CI to push the image to GitHub packages so developers can trigger the CI to update the image.

Why do we need to update the image? Why not add targets when image is used?

Adding targets later means you need to do it for every docker image run. Updating the version is not a highly frequent operation.

@usamoi
Copy link
Contributor Author

usamoi commented Nov 21, 2024

If you change the toolchain version, you may need to update the image. I'll create a CI to push the image to GitHub packages so developers can trigger the CI to update the image.

Why do we need to update the image? Why not add targets when image is used?

Adding targets later means you need to do it for every docker image run. Updating the version is not a highly frequent operation.

I think adding a target takes less than one second on Github actions and downloading the docker image takes more than one. If we want it to be faster, we should remove docker for first.

@kemingy
Copy link
Member

kemingy commented Nov 21, 2024

Adding targets costs about 17.8s in GitHub CI. Downloading the whole image is about 53s for now, almost the same as downloading from Docker Hub. I thought accessing ghcr should be much faster.

@usamoi
Copy link
Contributor Author

usamoi commented Nov 21, 2024

Adding targets costs about 17.8s in GitHub CI.

Screenshot_20241121_204825

Their servers must be on the moon or Mars. It takes only 4 seconds even on my machine.

@usamoi usamoi merged commit c4ac1c0 into tensorchord:main Nov 21, 2024
9 checks passed
@usamoi usamoi deleted the fast-forward branch November 21, 2024 12:52
usamoi added a commit that referenced this pull request Jan 8, 2025
pick #106, #147 and #149 to vchordrqfscan

Signed-off-by: usamoi <usamoi@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants