Skip to content

Capture panic in replication task processing #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 12, 2023
Merged

Capture panic in replication task processing #3799

merged 4 commits into from
Jan 12, 2023

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Jan 11, 2023

What changed?

  • Capture panic in replication task processing

Why?

  • Stability, task can be put to DLQ, instead of crash entire history host.
  • For DLQ task processing, it currently done via api call and we already have panic wrapper there.

How did you test it?

  • Unit test

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from yux0 January 11, 2023 02:09
@yycptt yycptt requested a review from a team as a code owner January 11, 2023 02:09
@yycptt yycptt merged commit 5b182a7 into temporalio:master Jan 12, 2023
@yycptt yycptt deleted the replication-task-panic-wrapper branch January 12, 2023 00:25
@yycptt yycptt added the release/1.19.1 Patches for v1.19.1 label Jan 12, 2023
yycptt added a commit that referenced this pull request Jan 12, 2023
@yycptt
Capture panic in replication task processing (#3799)
c221288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

Assignees
No one assigned
Labels
release/1.19.1 Patches for v1.19.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @yux0