Skip to content

Conversation

vaibhavyadav-dev
Copy link
Contributor

@vaibhavyadav-dev vaibhavyadav-dev commented Jul 23, 2025

What changed?

  • Added FailoverVersionIncrement and InitialFailoverVersion fields to the GetClusterInfoResponse protobuf message.
  • These fields are available on the server side but were missing from the API response, causing incomplete output for
    operator cluster describe -o json

Why?

Closes #7294

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

bergundy added a commit to temporalio/api that referenced this pull request Jul 25, 2025
Added two new fields to the `GetClusterInfoResponse` proto:

```protobuf
  int64 failover_version_increment = 9;
  int64 initial_failover_version   = 10;
```

[Server PR](temporalio/temporal#8090)

---------

Co-authored-by: Roey Berman <roey.berman@gmail.com>
temporal-cicd bot pushed a commit to temporalio/api-go that referenced this pull request Jul 25, 2025
Added two new fields to the `GetClusterInfoResponse` proto:

```protobuf
  int64 failover_version_increment = 9;
  int64 initial_failover_version   = 10;
```

[Server PR](temporalio/temporal#8090)

---------

Co-authored-by: Roey Berman <roey.berman@gmail.com>
Copy link
Member

@yycptt yycptt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this also need to have the api version upgraded.

We are in a release process right now and need to ping api dependency to a tagged version. So just blocking this PR for one day and I will approve the PR tomorrow.

@bergundy
Copy link
Member

@vaibhavyadav-dev you will need to go get -u go.temporal.io/api@master and go mod tidy for this to pass.

@vaibhavyadav-dev vaibhavyadav-dev force-pushed the fix/7294-cluster-failover-fields branch from 36d1004 to 602e9b2 Compare July 26, 2025 04:21
@bergundy bergundy changed the title Added failoverVersionIncrement & initialFailoverVersion in GetCluster… Added failoverVersionIncrement & initialFailoverVersion in GetClusterInfo Jul 30, 2025
@bergundy bergundy changed the title Added failoverVersionIncrement & initialFailoverVersion in GetClusterInfo Add failoverVersionIncrement & initialFailoverVersion in GetClusterInfo Jul 30, 2025
@bergundy bergundy enabled auto-merge (squash) July 30, 2025 13:12
@bergundy bergundy merged commit ada5d0b into temporalio:main Jul 30, 2025
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

operator cluster describe not showing failoverVersionIncrement and initialFailoverVersion
3 participants