Skip to content

Conversation

ychebotarev
Copy link
Contributor

@ychebotarev ychebotarev commented Jul 24, 2025

What changed?

  • Add implementation for DescribeWorker API (to both frontend and matching)
  • Add feature flag
  • Add all quotas/etc.
  • Add unit tests
  • Add functional tests

Why?

Part of worker commands work.
Users should be able to directly get worker info for the worker they need.
Corresponding API PR: temporalio/api#622

How did you test it?

  • add unit tests
  • add functional tests

Potential risks

None, behind feature flag

@ychebotarev ychebotarev requested a review from a team as a code owner July 24, 2025 17:46
@ychebotarev ychebotarev changed the title stub for DescribeWorker API Implementation for DescribeWorker API Jul 25, 2025
ychebotarev added a commit to temporalio/api that referenced this pull request Jul 25, 2025
<!-- Describe what has changed in this PR -->
**What changed?**
Add DescribeWorker API.
Extracted from [this PR](#622). 

<!-- Tell your future self why have you made these changes -->
DescribeWorker - will be needed to get all the heartbeat information
from the worker.
Partially this can be covered by "ListWorkers" with query
"WorkerInstanceKey = 'xxx'", but this is a dedicated API that doesn't
require query processing.

Extracting into separate PR so that one is concentrated on worker
payload only.

<!-- Are there any breaking changes on binary or code level? -->
**Breaking changes**
Introduce new API

<!-- If this breaks the Server, please provide the Server PR to merge
right after this PR was merged. -->
[Server PR](temporalio/temporal#8094)
temporal-cicd bot pushed a commit to temporalio/api-go that referenced this pull request Jul 25, 2025
<!-- Describe what has changed in this PR -->
**What changed?**
Add DescribeWorker API.
Extracted from [this PR](temporalio/api#622).

<!-- Tell your future self why have you made these changes -->
DescribeWorker - will be needed to get all the heartbeat information
from the worker.
Partially this can be covered by "ListWorkers" with query
"WorkerInstanceKey = 'xxx'", but this is a dedicated API that doesn't
require query processing.

Extracting into separate PR so that one is concentrated on worker
payload only.

<!-- Are there any breaking changes on binary or code level? -->
**Breaking changes**
Introduce new API

<!-- If this breaks the Server, please provide the Server PR to merge
right after this PR was merged. -->
[Server PR](temporalio/temporal#8094)
@ychebotarev ychebotarev merged commit 21cd558 into main Jul 25, 2025
85 of 87 checks passed
@ychebotarev ychebotarev deleted the y_describe_worker branch July 25, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants