TaskQueue per-priority stats in API #8030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c41265b to
4e63150
Compare
6b011d0 to
b2cf130
Compare
stephanos
commented
Jul 15, 2025
| WorkflowTaskTimeout: durationpb.New(10 * time.Minute), | ||
| RequestId: uuid.New(), | ||
| WorkflowIdReusePolicy: enumspb.WORKFLOW_ID_REUSE_POLICY_ALLOW_DUPLICATE, | ||
| Priority: &commonpb.Priority{PriorityKey: int32(priority)}, |
There was a problem hiding this comment.
This is a notable test update.
stephanos
commented
Jul 15, 2025
| @@ -102,7 +118,7 @@ func (s *TaskQueueStatsSuite) TestMultipleTasks_MultiplePartitions_WithMatchingB | |||
| s.OverrideDynamicConfig(dynamicconfig.TaskQueueInfoByBuildIdTTL, 1*time.Millisecond) // zero means no TTL | |||
|
|
|||
| s.RunTestWithMatchingBehavior(func() { | |||
| s.publishConsumeWorkflowTasksValidateStats(50, false) // 25 unversioned, 25 versioned | |||
There was a problem hiding this comment.
Changed these from totals to "sets".
stephanos
commented
Jul 15, 2025
| }, 5*time.Second, 100*time.Millisecond) | ||
| } | ||
|
|
||
| func validateTaskQueueStatsByPriority( |
There was a problem hiding this comment.
This is a net new set of assertions.
dnr
approved these changes
Jul 21, 2025
tests/task_queue_stats_test.go
Outdated
| // Unless a test calls out a specific methods, all three methods are tested in each test case. | ||
| func TestTaskQueueStatsSuite(t *testing.T) { | ||
| // TODO(pri): remove once the classic matcher is removed | ||
| func TestTaskQueueStatsSuite_ClassicMatcher(t *testing.T) { |
There was a problem hiding this comment.
the naming scheme for the others is:
Suggested change
| func TestTaskQueueStatsSuite_ClassicMatcher(t *testing.T) { | |
| func TestTaskQueueStats_Classic_Suite(t *testing.T) { |
I don't care that much but just keep them easy to type and consistent
stephanos
added a commit
to temporalio/api
that referenced
this pull request
Jul 22, 2025
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** Adding a breakdown of stats per-priority levels to the two APIs that return task queue stats already. <!-- Tell your future self why have you made these changes --> **Why?** To give users insights on a per priority level. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** N/A <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** temporalio/temporal#8030
temporal-cicd bot
pushed a commit
to temporalio/api-go
that referenced
this pull request
Jul 22, 2025
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** Adding a breakdown of stats per-priority levels to the two APIs that return task queue stats already. <!-- Tell your future self why have you made these changes --> **Why?** To give users insights on a per priority level. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** N/A <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** temporalio/temporal#8030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding a breakdown of stats per-priority levels to the two APIs that return task queue stats already.
Why?
New API is defined here: temporalio/api#611.
How did you test it?