Stubs for RecordWorkerHeartbeat and ListWorkers #7870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnr
reviewed
Jun 5, 2025
ychebotarev
added a commit
to temporalio/api
that referenced
this pull request
Jun 5, 2025
<!-- Describe what has changed in this PR --> **What changed?** What changed? * 2 new APIs added: * WorkerHeartbeat * ListWorkerStatus * WorkerInfo information added to: * ShutDownWorker request * Poll(Activity|Nexus|Workflow)TaskQueue requests This is "for merge". Here is a previous PR, where we discuss this at length: #599 <!-- Tell your future self why have you made these changes --> **Why?** Part of the worker visibility work. Workers should be able to report their status. Users should be able to get information about workers. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** Yes - new API is introduce. <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** [Server PR](temporalio/temporal#7870)
temporal-cicd bot
pushed a commit
to temporalio/api-go
that referenced
this pull request
Jun 5, 2025
<!-- Describe what has changed in this PR --> **What changed?** What changed? * 2 new APIs added: * WorkerHeartbeat * ListWorkerStatus * WorkerInfo information added to: * ShutDownWorker request * Poll(Activity|Nexus|Workflow)TaskQueue requests This is "for merge". Here is a previous PR, where we discuss this at length: temporalio/api#599 <!-- Tell your future self why have you made these changes --> **Why?** Part of the worker visibility work. Workers should be able to report their status. Users should be able to get information about workers. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** Yes - new API is introduce. <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** [Server PR](temporalio/temporal#7870)
dnr
approved these changes
Jun 6, 2025
Shivs11
pushed a commit
that referenced
this pull request
Jun 6, 2025
Add stubs for new API: * RecordWorkerHeartbeat * ListWorkers Also add feature flags Adding new API is a breaking change, we need stubs. Corresponding API PR: #7870 - [x] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
yycptt
reviewed
Jun 10, 2025
| @@ -142,6 +142,8 @@ var ( | |||
| "/temporal.api.workflowservice.v1.WorkflowService/ResetStickyTaskQueue": 5, | |||
| "/temporal.api.workflowservice.v1.WorkflowService/ShutdownWorker": 5, | |||
| "/temporal.api.workflowservice.v1.WorkflowService/GetWorkflowExecutionHistoryReverse": 5, | |||
| "/temporal.api.workflowservice.v1.WorkflowService/RecordWorkerHeartbeat": 5, | |||
There was a problem hiding this comment.
cc @prathyushpv Do we need to update OPS for this? What's the default priority for new APIs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add stubs for new API:
Also add feature flags
Why?
Adding new API is a breaking change, we need stubs.
Corresponding API PR:
#7870
How did you test it?