Add VersionStatus in WorkerDeploymentVersionInfo + WorkerDeploymentVersionSummary
#7804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shivs11
commented
May 28, 2025
| @@ -1079,7 +1079,7 @@ func (d *ClientImpl) updateWithStartWorkerDeploymentVersion( | |||
| BuildId: buildID, | |||
| }, | |||
| CreateTime: now, | |||
| RoutingUpdateTime: now, | |||
| RoutingUpdateTime: nil, | |||
There was a problem hiding this comment.
this was wrong! we should never set the routingUpdateTime when starting a version workflow
Shivs11
commented
May 28, 2025
| @@ -984,47 +987,6 @@ func (s *DeploymentVersionSuite) TestVersionMissingTaskQueues_InvalidSetRampingV | |||
| s.EqualErrorf(err, workerdeployment.ErrRampingVersionDoesNotHaveAllTaskQueues, err.Error()) | |||
| } | |||
|
|
|||
| func (s *DeploymentVersionSuite) setRamping( | |||
There was a problem hiding this comment.
don't worry - just moved these helpers to the bottom of the file so they all look nice together
ShahabT
approved these changes
May 28, 2025
Shivs11
added a commit
to temporalio/api
that referenced
this pull request
May 28, 2025
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** - add VersionStatus inside `WorkerDeploymentVersionInfo` + `WorkerDeploymentVersionSummary` <!-- Tell your future self why have you made these changes --> **Why?** - right now, the UI code deduces the status of a version by checking `CurrentSince`, `RampingSince` and other attributes. This can just be simplified by adding this enum and the server doing the heavy lifting instead. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** - None <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** - [741011](temporalio/temporal#7804)
temporal-cicd bot
pushed a commit
to temporalio/api-go
that referenced
this pull request
May 28, 2025
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** - add VersionStatus inside `WorkerDeploymentVersionInfo` + `WorkerDeploymentVersionSummary` <!-- Tell your future self why have you made these changes --> **Why?** - right now, the UI code deduces the status of a version by checking `CurrentSince`, `RampingSince` and other attributes. This can just be simplified by adding this enum and the server doing the heavy lifting instead. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** - None <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** - [741011](temporalio/temporal#7804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks