Describe closed Deployment Workflows returns NotFound + test ListDeployments excludes closed #7267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahabT
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
This works, but I wonder if it was better for the query handler to just return an error when the wf is closed rather than pushing logic of checking closed to the client. That way, keeping just a in-memory bool in wf memory would be enough, without need for augmenting protos.
ShahabT
reviewed
Feb 6, 2025
616671c to
b5acfe9
Compare
cb8cb13 to
78bf2db
Compare
122d338 to
9140a68
Compare
7f29cf3 to
bf3c34c
Compare
ShahabT
added a commit
that referenced
this pull request
Feb 6, 2025
…oyments excludes closed (#7267) ## What changed? Make describe closed wf return not found and add tests ## Why? <!-- Tell your future self why have you made these changes --> ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> --------- Co-authored-by: ShahabT <shahab.tajik@temporal.io> Co-authored-by: Shivam Saraf <shivam.saraf@temporal.io>
ShahabT
added a commit
that referenced
this pull request
Feb 6, 2025
…oyments excludes closed (#7267) ## What changed? Make describe closed wf return not found and add tests ## Why? <!-- Tell your future self why have you made these changes --> ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) --> --------- Co-authored-by: ShahabT <shahab.tajik@temporal.io> Co-authored-by: Shivam Saraf <shivam.saraf@temporal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Make describe closed wf return not found and add tests
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?