Add batch activity unpause. Single activity commulative changes #7169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2025
alexshtin
reviewed
Jan 29, 2025
|
I think you need at least one basic functional test for batch operation.
Will be a separate PR |
alexshtin
approved these changes
Jan 30, 2025
ychebotarev
added a commit
to temporalio/api
that referenced
this pull request
Jan 30, 2025
<!-- Describe what has changed in this PR --> **What changed?** Add batch activity unpause operation. <!-- Tell your future self why have you made these changes --> **Why?** Part of the activity API work. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** No <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** [Add batch activity unpause. Single activity commulative changes](temporalio/temporal#7169)
temporal-cicd bot
pushed a commit
to temporalio/api-go
that referenced
this pull request
Jan 30, 2025
<!-- Describe what has changed in this PR --> **What changed?** Add batch activity unpause operation. <!-- Tell your future self why have you made these changes --> **Why?** Part of the activity API work. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** No <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** [Add batch activity unpause. Single activity commulative changes](temporalio/temporal#7169)
ychebotarev
added a commit
to temporalio/api
that referenced
this pull request
Jan 30, 2025
<!-- Describe what has changed in this PR --> **What changed?** This PR contains a commutative feedback for single activity API: * add 'jitter' fields to Reset and Unpause * 'Flatten' unpause. Previous approach was marked as overcomplicated * Add 'keep_unpause' flag to Reset. By default reset will also unpause the activity. * Remove no-wait flag. By default, if activity is in retry, they will be scheduled immediately (*jitter) * Add "activity type" as a routing parameter to every activity operation. If activity type is provided - every pending activity of this type will be paused/reset/updated/unpaused * Update API descriptions to reflect those changes. <!-- Tell your future self why have you made these changes --> **Why?** Working on single activity API feedback from the design review. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** Yes <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** [Add batch activity unpause. Single activity commulative changes](temporalio/temporal#7169)
temporal-cicd bot
pushed a commit
to temporalio/api-go
that referenced
this pull request
Jan 30, 2025
<!-- Describe what has changed in this PR --> **What changed?** This PR contains a commutative feedback for single activity API: * add 'jitter' fields to Reset and Unpause * 'Flatten' unpause. Previous approach was marked as overcomplicated * Add 'keep_unpause' flag to Reset. By default reset will also unpause the activity. * Remove no-wait flag. By default, if activity is in retry, they will be scheduled immediately (*jitter) * Add "activity type" as a routing parameter to every activity operation. If activity type is provided - every pending activity of this type will be paused/reset/updated/unpaused * Update API descriptions to reflect those changes. <!-- Tell your future self why have you made these changes --> **Why?** Working on single activity API feedback from the design review. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** Yes <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** [Add batch activity unpause. Single activity commulative changes](temporalio/temporal#7169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
TODO: separate func tests for batch unpause.
Why?
Part of the activity API work.
How did you test it?
fixing and running unit/func tests
Potential risks
N/A
Documentation
Not for now.
Is hotfix candidate?
No