Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: temporalio/api-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.49.0
Choose a base ref
...
head repository: temporalio/api-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.49.1
Choose a head ref
  • 6 commits
  • 159 files changed
  • 6 contributors

Commits on May 2, 2025

  1. Add reset info to the activity heartbeat response (#578)

    <!-- Describe what has changed in this PR -->
    **What changed?**
    Add two new flags to activity heartbeat response:
    * reset_requested // indicates that reset happen while activity is still
    running
    * reset_heartbeat //indicates that user asked to also reset heartbeats
    
    <!-- Tell your future self why have you made these changes -->
    **Why?**
    Product request.
    
    <!-- Are there any breaking changes on binary or code level? -->
    **Breaking changes**
    No
    
    Corresponding Server PR:
    temporalio/temporal#7677
    ychebotarev committed May 2, 2025
    Configuration menu
    Copy the full SHA
    9b54d4a View commit details
    Browse the repository at this point in the history

Commits on May 5, 2025

  1. Remove per file copyright headers (#584)

    <!-- Describe what has changed in this PR -->
    **What changed?**
    Removed all copyright headers from individual files.
    
    <!-- Tell your future self why have you made these changes -->
    **Why?**
    Per-file license no longer needed
    
    Closes #583
    
    <!-- Are there any breaking changes on binary or code level? -->
    **Breaking changes**
    Comment only change
    
    <!-- If this breaks the Server, please provide the Server PR to merge
    right after this PR was merged. -->
    **Server PR**
    yuandrew committed May 5, 2025
    Configuration menu
    Copy the full SHA
    a160dbc View commit details
    Browse the repository at this point in the history
  2. Remove per-file copyright headers (#220)

    * Remove copyright headers from code
    
    * Remove copyright header from proxy generator, ingest api changes
    yuandrew authored May 5, 2025
    Configuration menu
    Copy the full SHA
    618801d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bf06cf5 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2025

  1. Add activity options to the pending activity info (#586)

    _**READ BEFORE MERGING:** All PRs require approval by both Server AND
    SDK teams before merging! This is why the number of required approvals
    is "2" and not "1"--two reviewers from the same team is NOT sufficient.
    If your PR is not approved by someone in BOTH teams, it may be summarily
    reverted._
    
    <!-- Describe what has changed in this PR -->
    **What changed?**
    Add activity options to the pending activity info
    
    <!-- Tell your future self why have you made these changes -->
    **Why?**
    If activity options where changed - there is no "official" way to users
    to know what are the current options.
    UI should display current options, so we will provide them as a part of
    DescribeWorfklow response.
    Thus we add activity options to the pending activity info, which will be
    a part of DescribeWorfklow response.
    
    <!-- Are there any breaking changes on binary or code level? -->
    **Breaking changes**
    No
    ychebotarev committed May 9, 2025
    Configuration menu
    Copy the full SHA
    4c3944c View commit details
    Browse the repository at this point in the history

Commits on May 13, 2025

  1. change Version to struct, prevent misconfiguration of VersioningOverr…

    …ide (#579)
    
    _**READ BEFORE MERGING:** All PRs require approval by both Server AND
    SDK teams before merging! This is why the number of required approvals
    is "2" and not "1"--two reviewers from the same team is NOT sufficient.
    If your PR is not approved by someone in BOTH teams, it may be summarily
    reverted._
    
    What changed?
    - Make override a one of and add different pinned override types.
    - Change version from string to struct
    - Make nil Version represent "send tasks away from versioned workers and
    to unversioned workers"
    
    Why?
    - To prevent misconfiguration and to expand the override definition to
    accommodate the new PinnedUntilContinueAsNew behaviors.
    - Using a string to represent structured data, whose subfields
    frequently need to be considered separately, is brittle and not good for
    anyone using it. Struct is better.
    - "unversioned version" is contradictory, and nil is a nice way to
    represent that the versioning story of a task queue is no longer in the
    control of the Deployment whose `RoutingConfig` you are reading.
    
    <!-- Are there any breaking changes on binary or code level? -->
    Variables are being deprecated, but the content of the code is not
    changing.
    The idea of "Unset Ramp" having a separate meaning from "0% Ramp" is
    removed. 0% ramp now is the only way to have "no ramp" / 100% of traffic
    going to Current Version. Nil `ramping_deployment_version` + non-zero
    `ramping_version_percentage` is the way to ramp traffic to unversioned
    workers.
    
    The SDK interface for this could look like:
    ```
    deployment := client.GetHandle(deploymentName)
    
    // set current to a version
    deployment.SetCurrentVersion(buildId) -> current set to deploymentName/buildId
    deployment.UnsetCurrentVersion() -> current set to nil
    
    // set current to unversioned
    deployment.UnsetCurrentVersion() -> current set to nil
    
    deployment.SetRampingVersion(buildId, 50) -> ramp set to (deploymentName/buildId, 50)
    deployment.UnsetRampingVersion() -> ramp set to (nil, 0%)
    deployment.RampToUnversioned(50) -> set to (nil, 50%)
    ```
    
    <!-- If this breaks the Server, please provide the Server PR to merge
    right after this PR was merged. -->
    **Server PR**
    
    ---------
    
    Co-authored-by: Spencer Judge <spencer@temporal.io>
    Co-authored-by: Shahab Tajik <shahab@temporal.io>
    3 people committed May 13, 2025
    Configuration menu
    Copy the full SHA
    cde9f12 View commit details
    Browse the repository at this point in the history
Loading