-
Notifications
You must be signed in to change notification settings - Fork 37
Comparing changes
Open a pull request
base repository: temporalio/api-go
base: v1.49.0
head repository: temporalio/api-go
compare: v1.49.1
- 6 commits
- 159 files changed
- 6 contributors
Commits on May 2, 2025
-
Add reset info to the activity heartbeat response (#578)
<!-- Describe what has changed in this PR --> **What changed?** Add two new flags to activity heartbeat response: * reset_requested // indicates that reset happen while activity is still running * reset_heartbeat //indicates that user asked to also reset heartbeats <!-- Tell your future self why have you made these changes --> **Why?** Product request. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** No Corresponding Server PR: temporalio/temporal#7677
Configuration menu - View commit details
-
Copy full SHA for 9b54d4a - Browse repository at this point
Copy the full SHA 9b54d4aView commit details
Commits on May 5, 2025
-
Remove per file copyright headers (#584)
<!-- Describe what has changed in this PR --> **What changed?** Removed all copyright headers from individual files. <!-- Tell your future self why have you made these changes --> **Why?** Per-file license no longer needed Closes #583 <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** Comment only change <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR**
Configuration menu - View commit details
-
Copy full SHA for a160dbc - Browse repository at this point
Copy the full SHA a160dbcView commit details -
Remove per-file copyright headers (#220)
* Remove copyright headers from code * Remove copyright header from proxy generator, ingest api changes
Configuration menu - View commit details
-
Copy full SHA for 618801d - Browse repository at this point
Copy the full SHA 618801dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf06cf5 - Browse repository at this point
Copy the full SHA bf06cf5View commit details
Commits on May 9, 2025
-
Add activity options to the pending activity info (#586)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** Add activity options to the pending activity info <!-- Tell your future self why have you made these changes --> **Why?** If activity options where changed - there is no "official" way to users to know what are the current options. UI should display current options, so we will provide them as a part of DescribeWorfklow response. Thus we add activity options to the pending activity info, which will be a part of DescribeWorfklow response. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** No
Configuration menu - View commit details
-
Copy full SHA for 4c3944c - Browse repository at this point
Copy the full SHA 4c3944cView commit details
Commits on May 13, 2025
-
change Version to struct, prevent misconfiguration of VersioningOverr…
…ide (#579) _**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ What changed? - Make override a one of and add different pinned override types. - Change version from string to struct - Make nil Version represent "send tasks away from versioned workers and to unversioned workers" Why? - To prevent misconfiguration and to expand the override definition to accommodate the new PinnedUntilContinueAsNew behaviors. - Using a string to represent structured data, whose subfields frequently need to be considered separately, is brittle and not good for anyone using it. Struct is better. - "unversioned version" is contradictory, and nil is a nice way to represent that the versioning story of a task queue is no longer in the control of the Deployment whose `RoutingConfig` you are reading. <!-- Are there any breaking changes on binary or code level? --> Variables are being deprecated, but the content of the code is not changing. The idea of "Unset Ramp" having a separate meaning from "0% Ramp" is removed. 0% ramp now is the only way to have "no ramp" / 100% of traffic going to Current Version. Nil `ramping_deployment_version` + non-zero `ramping_version_percentage` is the way to ramp traffic to unversioned workers. The SDK interface for this could look like: ``` deployment := client.GetHandle(deploymentName) // set current to a version deployment.SetCurrentVersion(buildId) -> current set to deploymentName/buildId deployment.UnsetCurrentVersion() -> current set to nil // set current to unversioned deployment.UnsetCurrentVersion() -> current set to nil deployment.SetRampingVersion(buildId, 50) -> ramp set to (deploymentName/buildId, 50) deployment.UnsetRampingVersion() -> ramp set to (nil, 0%) deployment.RampToUnversioned(50) -> set to (nil, 50%) ``` <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** --------- Co-authored-by: Spencer Judge <spencer@temporal.io> Co-authored-by: Shahab Tajik <shahab@temporal.io>
Configuration menu - View commit details
-
Copy full SHA for cde9f12 - Browse repository at this point
Copy the full SHA cde9f12View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.49.0...v1.49.1