Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: temporalio/api-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.43.2
Choose a base ref
...
head repository: temporalio/api-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.44.0
Choose a head ref
  • 15 commits
  • 76 files changed
  • 9 contributors

Commits on Jan 17, 2025

  1. GHA check sdk-go compatibility (#200)

    * GHA check sdk-go compatibility
    
    * address comments
    
    * address comments
    
    * tee
    rodrigozhou authored Jan 17, 2025
    Configuration menu
    Copy the full SHA
    ea3c80c View commit details
    Browse the repository at this point in the history
  2. GHA to create release (#170)

    * GHA to create tags/releases
    
    * address comments
    
    * address comments
    
    * create var
    rodrigozhou authored Jan 17, 2025
    Configuration menu
    Copy the full SHA
    ab9485d View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2025

  1. GHA to create release (#437)

    <!-- Describe what has changed in this PR -->
    **What changed?**
    GHA to create, publish and delete releases.
    - `create-release`: manually triggered, it validates the input, checks
    compatibility with sdk-go, and creates draft releases in `api` and
    `api-go`.
    - `publish-release`: triggered when a release is published, it publishes
    the corresponding `api-go` release.
    - `delete-release`: triggered when a release is deleted, it deletes the
    corresponding `api-go` release (only works for deleting draft releases).
    
    <!-- Tell your future self why have you made these changes -->
    **Why?**
    Automation.
    
    <!-- Are there any breaking changes on binary or code level? -->
    **Breaking changes**
    
    <!-- If this breaks the Server, please provide the Server PR to merge
    right after this PR was merged. -->
    **Server PR**
    rodrigozhou committed Jan 18, 2025
    Configuration menu
    Copy the full SHA
    c8112d7 View commit details
    Browse the repository at this point in the history
  2. add unset_versioning_override to WorkflowExecutionOptionsUpdatedEvent…

    …Attributes (#516)
    
    _**READ BEFORE MERGING:** All PRs require approval by both Server AND
    SDK teams before merging! This is why the number of required approvals
    is "2" and not "1"--two reviewers from the same team is NOT sufficient.
    If your PR is not approved by someone in BOTH teams, it may be summarily
    reverted._
    
    <!-- Describe what has changed in this PR -->
    ### What:
    
    Add unset_versioning_override to
    WorkflowExecutionOptionsUpdatedEventAttributes
    
    <!-- Tell your future self why have you made these changes -->
    ### Why:
    
    So that users of this event don't need to load VersioningOverride from
    mutable state every time they create this event.
    This change was prompted because the event is now being used for
    non-version-override-related things, and I received feedback that it is
    inefficient / awkward / error-prone to have to load and pass in the
    current versioning override every time anyone writes to this event.
    
    Now, a nil Versioning Override in this event means "no change" instead
    of "remove".
    This reduces the chance that someone accidentally unsets an override in
    the future, and also is more efficient.
    We've discussed this change internally in the server team and are ok
    with changing the meaning of this history event, because it is such a
    small change and the scope of impact is small (pre-release versioning
    users who have unset a versioning override and are building mutable
    state from that history).
    
    <!-- Are there any breaking changes on binary or code level? -->
    ### Breaking changes?
    
    Now, a nil Versioning Override in this event means "no change" instead
    of "remove".
    If an event exists with the previous meaning and the mutable state is
    rebuilt, the Versioning Override would not be removed.
    But the chance of that happening is very low.
    
    <!-- If this breaks the Server, please provide the Server PR to merge
    right after this PR was merged. -->
    temporalio/temporal#7091
    carlydf committed Jan 18, 2025
    Configuration menu
    Copy the full SHA
    0e5a507 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2025

  1. Remove disabling UTF-8 validation hack (#205)

    **What changed?**
    Remove the hack to allow disabling UTF-8 validation on our Go protos.
    
    **Why?**
    We should allow protobuf to validate all strings are valid UTF-8 as specified.
    
    **How did you test it?**
    Will be tested by server, sdk, and other components.
    
    **Potential risks**
    Anyone still using invalid UTF-8 will see their grpc requests fail. We've been monitoring for this in Temporal Cloud for most of a year now and there's no more invalid data. Self-hosted users should do the same validation before upgrading to a server or Go SDK release that contains this change (instructions [here](https://github.com/temporalio/temporal/releases/tag/v1.24.0)).
    dnr authored Jan 24, 2025
    Configuration menu
    Copy the full SHA
    a53ea3f View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2025

  1. pull api/cmd/protogen@master instead of @latest while latest is incom…

    …patible with latest protoc-gen packages (#531)
    
    _**READ BEFORE MERGING:** All PRs require approval by both Server AND
    SDK teams before merging! This is why the number of required approvals
    is "2" and not "1"--two reviewers from the same team is NOT sufficient.
    If your PR is not approved by someone in BOTH teams, it may be summarily
    reverted._
    
    <!-- Describe what has changed in this PR -->
    pull api/cmd/protogen@master instead of @latest while latest is
    incompatible with latest protoc-gen packages
    
    <!-- Tell your future self why have you made these changes -->
    To fix the panic error caused by installing @latest of all packages in
    `make grpc-install`
    ```
    panic: interface conversion: ast.Expr is *ast.CallExpr, not *ast.CompositeLit
    
    goroutine 1 [running]:
    main.(*disableUtf8Validation).visit(0x0?, {0x1044665a8?, 0x1400039a480?})
            /Users/cdf/go/pkg/mod/go.temporal.io/api@v1.43.2/cmd/protogen/disable_utf8.go:90 +0x484
    go/ast.inspector.Visit(0x140003a20b0, {0x1044665a8?, 0x1400039a480?})
    ```
    
    Another option would be to figure out which of these other versions
    caused the problem and pin that package to an older version that is
    compatible with v1.43.2 of our api-go repo, but that requires a lot more
    work to narrow down the right combination of versions.
    
    If we want to pin to an old version instead, it would need to be an
    older version of one of these packages:
    ```
    Install/update protoc and plugins...
    go: downloading google.golang.org/protobuf v1.36.4
    go: downloading google.golang.org/grpc v1.70.0
    go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.26.0
    go: downloading google.golang.org/grpc v1.69.4
    go: downloading google.golang.org/protobuf v1.36.3
    go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20250115164207-1a7da9e5054f
    go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20250115164207-1a7da9e5054f
    go: downloading github.com/mikefarah/yq/v4 v4.45.1
    go: downloading github.com/goccy/go-json v0.10.4
    go: downloading github.com/elliotchance/orderedmap v1.7.1
    go: downloading github.com/goccy/go-yaml v1.13.3
    go: downloading github.com/magiconair/properties v1.8.9
    go: downloading golang.org/x/net v0.33.0
    ```
    
    <!-- Are there any breaking changes on binary or code level? -->
    **Breaking changes**
    
    <!-- If this breaks the Server, please provide the Server PR to merge
    right after this PR was merged. -->
    **Server PR**
    carlydf committed Jan 25, 2025
    Configuration menu
    Copy the full SHA
    a9a23b4 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2025

  1. Add batch activity unpause operation (#535)

    <!-- Describe what has changed in this PR -->
    **What changed?**
    Add batch activity unpause operation.
    
    <!-- Tell your future self why have you made these changes -->
    **Why?**
    Part of the activity API work.
    
    <!-- Are there any breaking changes on binary or code level? -->
    **Breaking changes**
    No
    
    <!-- If this breaks the Server, please provide the Server PR to merge
    right after this PR was merged. -->
    **Server PR**
    [Add batch activity unpause. Single activity commulative
    changes](temporalio/temporal#7169)
    ychebotarev committed Jan 30, 2025
    Configuration menu
    Copy the full SHA
    ef33bba View commit details
    Browse the repository at this point in the history
  2. Single Activity API changes (#534)

    <!-- Describe what has changed in this PR -->
    **What changed?**
    This PR  contains  a commutative feedback for single activity API:
    * add 'jitter' fields to Reset and Unpause
    * 'Flatten' unpause. Previous approach was marked as overcomplicated
    * Add 'keep_unpause' flag to Reset. By default reset will also unpause
    the activity.
    * Remove no-wait flag. By default, if activity is in retry, they will be
    scheduled immediately (*jitter)
    * Add "activity type" as a routing parameter to every activity
    operation. If activity type is provided - every pending activity of this
    type will be paused/reset/updated/unpaused
    * Update API descriptions to reflect those changes.
    
    <!-- Tell your future self why have you made these changes -->
    **Why?**
    Working on single activity API feedback from the design review.
    
    <!-- Are there any breaking changes on binary or code level? -->
    **Breaking changes**
    Yes
    
    <!-- If this breaks the Server, please provide the Server PR to merge
    right after this PR was merged. -->
    **Server PR**
    [Add batch activity unpause. Single activity commulative
    changes](temporalio/temporal#7169)
    ychebotarev committed Jan 30, 2025
    Configuration menu
    Copy the full SHA
    c83bb3e View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2025

  1. Add OnConflictOptions to StartWorkflowExecutionRequest (#510)

    _**READ BEFORE MERGING:** All PRs require approval by both Server AND
    SDK teams before merging! This is why the number of required approvals
    is "2" and not "1"--two reviewers from the same team is NOT sufficient.
    If your PR is not approved by someone in BOTH teams, it may be summarily
    reverted._
    
    <!-- Describe what has changed in this PR -->
    **What changed?**
    Add `OnConflictOptions` to `StartWorkflowExecutionRequest`
    
    <!-- Tell your future self why have you made these changes -->
    **Why?**
    When the workflow id conflict policy is `USE_EXISTING`,
    `OnConflictOptions` add the ability to change the existing running
    workflow.
    
    <!-- Are there any breaking changes on binary or code level? -->
    **Breaking changes**
    
    <!-- If this breaks the Server, please provide the Server PR to merge
    right after this PR was merged. -->
    **Server PR**
    temporalio/temporal#7080
    rodrigozhou committed Feb 3, 2025
    Configuration menu
    Copy the full SHA
    1f14206 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2025

  1. Rename Nexus Operation ID to token (#548)

    - Leave operation ID fields in tact and mark them as deprecated. We may
    delete (reserve) them later on.
    bergundy committed Feb 4, 2025
    Configuration menu
    Copy the full SHA
    ebd7fd7 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2025

  1. Configuration menu
    Copy the full SHA
    092f3b1 View commit details
    Browse the repository at this point in the history
  2. Versioning 3.1 APIs (#540)

    _**READ BEFORE MERGING:** All PRs require approval by both Server AND
    SDK teams before merging! This is why the number of required approvals
    is "2" and not "1"--two reviewers from the same team is NOT sufficient.
    If your PR is not approved by someone in BOTH teams, it may be summarily
    reverted._
    
    <!-- Describe what has changed in this PR -->
    **What changed?**
    - Renamed `DeploymentSeries` -> `WorkerDeployment` and `Deployment` ->
    `WorkerDeploymentVersion`.
    - Added the following experimental APIs:
      - ListWorkerDeployments
      - DescribeWorkerDeployment
      - DescribeWorkerDeploymentVersion
      - SetWorkerDeploymentCurrentVersion
      - SetWorkerDeploymentRampingVersion
      - UpdateWorkerVersionMetadata
      - DeleteWorkerDeployment
      - DeleteWorkerDeploymentVersion
    - Deprecated the following experimental APIs:
      - DescribeDeployment
      - ListDeployments
      - GetDeploymentReachability
      - GetCurrentDeployment
      - SetCurrentDeployment
    
    <!-- Tell your future self why have you made these changes -->
    **Why?**
    These are changes and improvements we made based on user feedback from
    the previous iteration.
    
    <!-- Are there any breaking changes on binary or code level? -->
    **Breaking changes**
    No breaking changes, the old APIs still work until cleaned up at a later
    point with all other old Versioning APIs.
    
    <!-- If this breaks the Server, please provide the Server PR to merge
    right after this PR was merged. -->
    **Server PR**
    temporalio/temporal#7233
    
    ---------
    
    Co-authored-by: Shivam <57200924+Shivs11@users.noreply.github.com>
    Co-authored-by: Shahab Tajik <shahab@temporal.io>
    Co-authored-by: ShahabT <shahab.tajik@temporal.io>
    4 people committed Feb 6, 2025
    Configuration menu
    Copy the full SHA
    482fd2a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2025

  1. Deprecate ScanWorkflowExecutions (#552)

    Deprecate ScanWorkflowExecutions
    jmbarzee committed Feb 7, 2025
    Configuration menu
    Copy the full SHA
    6126880 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43caff9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    44277ce View commit details
    Browse the repository at this point in the history
Loading