Don't kill box.watchable system fiber on reload #1741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a system fiber. Killing it might result in crashing Tarantool. Integration tests would fail without this patch after tarantool/tarantool#6813 is merged.
filonenko-mikhail
approved these changes
Feb 1, 2022
DifferentialOrange
added a commit
to tarantool/crud
that referenced
this pull request
Apr 15, 2022
Bump `cartridge` rock dependency to 2.7.4 in tests. Version 2.7.4 fixes critical bug related to cartridge hot reload killing `box.watchable` fiber and causing Tarantool to segfault [1]. 1. tarantool/cartridge#1741
DifferentialOrange
added a commit
to tarantool/crud
that referenced
this pull request
Apr 18, 2022
Bump `cartridge` rock dependency to 2.7.4 in tests. Version 2.7.4 fixes critical bug related to cartridge hot reload killing `box.watchable` fiber and causing Tarantool to segfault [1]. 1. tarantool/cartridge#1741
3 tasks
DifferentialOrange
added a commit
to tarantool/crud
that referenced
this pull request
Apr 20, 2022
Bump `cartridge` rock dependency to 2.7.4 in tests. Version 2.7.4 fixes critical bug related to cartridge hot reload killing `box.watchable` fiber and causing Tarantool to segfault [1]. 1. tarantool/cartridge#1741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a system fiber. Killing it might result in crashing Tarantool.
Integration tests would fail without this patch after tarantool/tarantool#6813 is merged.