tailscale: update state after modification functions for resources #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add calls to appropriate `Read` functions at the end of `Create` and `Update` functions to follow recommended best practices from HashiCorp. This is done to prevent scenarios where Terraform could otherwise have stale state after resource creation or update (from default or computed values being populated server side on the object as an example) which can result in unexpected drift in subsequent plan / apply operations. Fixes tailscale/corp#19698 Signed-off-by: Mario Minardi <mario@tailscale.com>
237ac26 to
b22944a
Compare
mpminardi
commented
May 1, 2024
| @@ -67,6 +67,9 @@ func testTailnetKeyStruct(reusable bool) tailscale.Key { | |||
|
|
|||
| func setKeyStep(reusable bool, recreateIfInvalid string) resource.TestStep { | |||
| return resource.TestStep{ | |||
| PreConfig: func() { | |||
| testServer.ResponseBody = testTailnetKeyStruct(reusable) | |||
There was a problem hiding this comment.
This change just makes sure the server is ready to respond with the expected data immediately since we now do a Read after the Create.
willnorris
approved these changes
May 2, 2024
mpminardi
added a commit
that referenced
this pull request
May 3, 2024
Adds calls to `Read` after doing `Create` or `Update` operations for the ACL resource. This resource was missed in #362 where it was added for other existing resources. Signed-off-by: Mario Minardi <mario@tailscale.com>
mpminardi
added a commit
that referenced
this pull request
May 3, 2024
Adds calls to `Read` after doing `Create` or `Update` operations for the ACL resource. This resource was missed in #362 where it was added for other existing resources. Fixes tailscale/corp#19698 Signed-off-by: Mario Minardi <mario@tailscale.com>
mpminardi
added a commit
that referenced
this pull request
May 6, 2024
Adds calls to `Read` after doing `Create` or `Update` operations for the ACL resource. This resource was missed in #362 where it was added for other existing resources. Fixes tailscale/corp#19698 Signed-off-by: Mario Minardi <mario@tailscale.com>
mpminardi
added a commit
that referenced
this pull request
May 6, 2024
Adds calls to `Read` after doing `Create` or `Update` operations for the ACL resource. This resource was missed in #362 where it was added for other existing resources. Fixes tailscale/corp#19698 Signed-off-by: Mario Minardi <mario@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add calls to appropriate
Readfunctions at the end ofCreateandUpdatefunctions to follow recommended best practices from HashiCorp. This is done to prevent scenarios where Terraform could otherwise have stale state after resource creation or update (from default or computed values being populated server side on the object as an example) which can result in unexpected drift in subsequent plan / apply operations.Fixes https://github.com/tailscale/corp/issues/19698