Pulse builder interface #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds documentation of all non-private member function and properties
Also fixes some typos
taalexander
approved these changes
Apr 24, 2020
1ucian0
added a commit
that referenced
this pull request
Dec 4, 2020
* optimize qubit usage in Pwl * optimize helper qubits in poly PR * optimize weighted adder * add reno * Optimize ancilla (#3) * added a method that implements piecewise polynomials that extends the piecewise linear class functionality, and a class to approximate the inverse function * release notes * updated header * removed header encoding * fixed ancilla * remove old files * Apply suggestions from code review Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Julien Gacon <gaconju@gmail.com> * don't include last breakpoint Co-authored-by: Luciano Bello <luciano.bello@ibm.com> Co-authored-by: Almudena Carrera Vazquez <almudenacarreravazquez@hotmail.com> Co-authored-by: Kevin Krsulich <kevin.krsulich@ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've fixed most of the docs build errors and pylint that shows up locally (I didn't find any cyclic imports warning)
Details and comments