Optimize allocated qubits in arithmetic circuits #5332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 2, 2020
* added a method that implements piecewise polynomials that extends the piecewise linear class functionality, and a class to approximate the inverse function * release notes * updated header * removed header encoding * fixed ancilla * remove old files * Apply suggestions from code review Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Julien Gacon <gaconju@gmail.com>
kdk
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5320
Fixes #5321
Fixes #5322.
Details and comments
Fixes:
PiecewiseLinearPauliRotationscan be re-used in each breakpoint intervalsPolynomialPauliRotations, to many helper qubits were allocated and alsomcrxandmcrzwere provided with helper qubits even though they don't support themWeightedAdderalso did not used the allocated helper qubitAlso deprecate the
WeightedAdder.num_ancilla_qubitsmethod in favor ofWeightedAdder.num_ancillasand actually use theAncillaRegistertype to construct Grover oracles more efficiently.