Skip to content

Conversation

wy193777
Copy link
Contributor

@wy193777 wy193777 commented Jun 19, 2024

Description of change

Update mssql allowed version to fix a vulneribility:
here

Pull-Request Checklist

@wy193777 wy193777 changed the title Update mssql allowed version fix: update mssql allowed version Jun 19, 2024
@invaderb
Copy link

is there any update on getting this deployed?

@bbevers2
Copy link

Fixes #11003

@invaderb
Copy link

Can we please get this merged it's been an issue for months and addresses a security concern.

@macleysousa, @pleerock, @AlexMesser

@pkuczynski
Copy link
Contributor

Fixes #10946

@sloughrey
Copy link

Also waiting on this one to resolve a high security vulnerability in the mssql package.

@ChedyMissaouiAsForvia
Copy link

@wy193777 @pkuczynski Can we move forward and merge/release this PR please ?

@pkuczynski
Copy link
Contributor

pkuczynski commented Sep 24, 2024

Nothing I can do, I am not typeorm maintainer unfrotunatelly...

@ChedyMissaouiAsForvia
Copy link

Nothing I can do, I am not typeorm maintainer unfrotunatelly...

Thank you for your reply :-)

@wy193777
Copy link
Contributor Author

I'm also not the maintainer of this project. The main maintainer is still active on github but seem haven't do anything on this project more than half year.

@stevendarby
Copy link

@pleerock what do you reckon? Is it time to make a comeback? :)

@wy193777 wy193777 changed the title fix: update mssql allowed version fix: update mssql allowed version to fix vulnerability. Dec 11, 2024
@nessatumamak
Copy link

Any projected timeline for this PR to be merged/released?

@OSA413
Copy link
Collaborator

OSA413 commented Dec 13, 2024

Any projected timeline for this PR to be merged/released?

merged - soon

@jorenvandeweyer
Copy link
Collaborator

This version should be added to the test matrix

@wy193777
Copy link
Contributor Author

Where is the tests matrix? I looked test related yml files inside .github folder and there is no test mention libary dependency versions. Seems only different not versions been tested.

@stim371
Copy link
Collaborator

stim371 commented Dec 31, 2024

Where is the tests matrix? I looked test related yml files inside .github folder and there is no test mention library dependency versions. Seems only different not versions been tested.

@wy193777 We don't have a matrix for specific driver versions yet, just the node versions. But you could add a matrix in the mssql step for all allowed versions and pass the variable down. I'm not quite sure how we'd get it into the dockerfiles, but maybe we just need to create a few versions so we can point to the right one.

@wy193777
Copy link
Contributor Author

Added matrix tests for mssql driver versions.

use 11.0.1 for mssql
wy193777 and others added 2 commits January 2, 2025 16:30
@coveralls
Copy link

Coverage Status

coverage: 72.373% (+0.003%) from 72.37%
when pulling 38db77b on wy193777:patch-1
into 7bea198 on typeorm:master.

@michaelbromley michaelbromley merged commit 3a51160 into typeorm:master Jan 20, 2025
62 checks passed
@tabkram
Copy link

tabkram commented Jan 21, 2025

Thanks for merging this @michaelbromley !

Could you share when it will be released please?

thanks

@michaelbromley
Copy link
Member

Hopefully in the next couple of weeks. Just coordinating with the previous maintainer to ensure we get the release process right.

aberonni pushed a commit to global-121/typeorm that referenced this pull request Mar 5, 2025
@sgarner sgarner mentioned this pull request Jun 15, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TypeOrm mssql peer dependency issue related to CVE-2024-35255