-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix: update mssql allowed version to fix vulnerability. #10933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
is there any update on getting this deployed? |
Fixes #11003 |
Can we please get this merged it's been an issue for months and addresses a security concern. |
Fixes #10946 |
Also waiting on this one to resolve a high security vulnerability in the mssql package. |
@wy193777 @pkuczynski Can we move forward and merge/release this PR please ? |
Nothing I can do, I am not typeorm maintainer unfrotunatelly... |
Thank you for your reply :-) |
I'm also not the maintainer of this project. The main maintainer is still active on github but seem haven't do anything on this project more than half year. |
@pleerock what do you reckon? Is it time to make a comeback? :) |
Any projected timeline for this PR to be merged/released? |
merged - soon |
This version should be added to the test matrix |
Where is the tests matrix? I looked test related yml files inside .github folder and there is no test mention libary dependency versions. Seems only different not versions been tested. |
@wy193777 We don't have a matrix for specific driver versions yet, just the node versions. But you could add a matrix in the mssql step for all allowed versions and pass the variable down. I'm not quite sure how we'd get it into the dockerfiles, but maybe we just need to create a few versions so we can point to the right one. |
Added matrix tests for mssql driver versions. |
use 11.0.1 for mssql
use 11.0.1
update mssql matrix version
Thanks for merging this @michaelbromley ! Could you share when it will be released please? thanks |
Hopefully in the next couple of weeks. Just coordinating with the previous maintainer to ensure we get the release process right. |
Description of change
Update mssql allowed version to fix a vulneribility:
here
Pull-Request Checklist
master
branchnpm run format
to apply prettier formattingnpm run test
passes with this change