Replace regex with startsWith / endsWith check for LIKE pattern detection #3932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giheon Do <dgh0001@naver.com>
f75fe97 to
95f0561
Compare
mp911de
added a commit
that referenced
this pull request
Jul 10, 2025
Refine conditional flow. See #3932
mp911de
pushed a commit
that referenced
this pull request
Jul 10, 2025
…tion. Signed-off-by: Giheon Do <dgh0001@naver.com> Closes #3932
mp911de
added a commit
that referenced
this pull request
Jul 10, 2025
Refine conditional flow. See #3932
|
Thank you for your contribution. That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace regex
%.*%withstartsWith/endsWithcheck for LIKE pattern detectionPreviously, each call to expression.matches("%.*%") incurred regex compilation and Matcher allocation overhead. Caching the pattern with
would avoid recompilation, but switching to startsWith("%") && endsWith("%") is even more efficient and more readable, so the implementation has been changed accordingly.
Let me know if you have any concerns or suggestions for further improvement.
Thank you for your time and consideration!