Skip to content

Remove usage of java.home system property in native image #43517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove usage of java.home system property in native image #43517

wants to merge 1 commit into from

Conversation

big-cir
Copy link
Contributor

@big-cir big-cir commented Dec 16, 2024 •
edited
Loading

Overview

  1. Provides an explicit null check.
  2. Prevents issues in native image mode.

@pivotal-cla
Copy link

@big-cir Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 16, 2024
@big-cir big-cir mentioned this pull request Dec 16, 2024
Closed
@mhalbritter mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Dec 17, 2024
@snicoll
Copy link
Member

snicoll commented Dec 26, 2024

@big-cir we can't proceed further and are waiting for you to sign the CLA.

@pivotal-cla
Copy link

@big-cir Thank you for signing the Contributor License Agreement!

@big-cir
Copy link
Contributor Author

big-cir commented Dec 26, 2024 •
edited
Loading

@snicoll I apologize for the inconvenience. Last time, the signature was not completed due to a bug

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 26, 2024
@mhalbritter mhalbritter changed the title Refactor System.getProperty("java.home") handling in native image Remove usage of java.home system property in native image Jan 16, 2025
@mhalbritter mhalbritter added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Jan 16, 2025
@mhalbritter mhalbritter added this to the 3.5.x milestone Jan 16, 2025
@mhalbritter mhalbritter self-assigned this Jan 24, 2025
mhalbritter pushed a commit that referenced this pull request Jan 24, 2025
@big-cir @mhalbritter
Remove "java.home" system property when running in a native image
017a71d 
See gh-43517
mhalbritter added a commit that referenced this pull request Jan 24, 2025
@mhalbritter
Polish "Remove "java.home" system property when running in a native i…
7c6dbbf 
…mage"

See gh-43517
@mhalbritter
Copy link
Contributor

Thanks @big-cir !

@mhalbritter mhalbritter modified the milestones: 3.5.x, 3.5.0-M2 Jan 24, 2025
@big-cir big-cir deleted the refactor-native-image-handling branch January 26, 2025 04:40
arefbehboudi pushed a commit to arefbehboudi/spring-boot that referenced this pull request Jan 29, 2025
@big-cir @arefbehboudi
Remove "java.home" system property when running in a native image
fc53443 
See spring-projectsgh-43517

Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
arefbehboudi pushed a commit to arefbehboudi/spring-boot that referenced this pull request Jan 29, 2025
@mhalbritter @arefbehboudi
Polish "Remove "java.home" system property when running in a native i…
2d349b5 
…mage"

See spring-projectsgh-43517

Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.5.0-M2
Development

Successfully merging this pull request may close these issues.
5 participants
@big-cir @pivotal-cla @snicoll @mhalbritter @spring-projects-issues