Use ThreadLocal.remove() instead of set(null) #46256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leak Signed-off-by: Giheon Do <dgh0001@naver.com>
wilkinsona
pushed a commit
that referenced
this pull request
Jul 3, 2025
Signed-off-by: Giheon Do <dgh0001@naver.com> See gh-46256
|
Thank you, @Dockerel. FWIW, I don't think there's much risk from a memory leak here. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ThreadLocal.remove() instead of set(null) to prevent memory leak
ThreadLocal.set(null)withThreadLocal.remove()to properly clear thread-local values.Previously,
ThreadLocal.set(null)was used to clear the ThreadLocal variable. However, this only sets the value to null and leaves an entry in the thread’s local variable map, which can lead to memory leaks. Instead, by usingThreadLocal.remove(), we can properly remove the ThreadLocal variable from the thread's local variable map, preventing memory leaks.I have reviewed the codebase, and this was the only place where set(null) needed to be replaced with remove().
Let me know if you have any concerns or suggestions for further improvement.
Thank you for your time and consideration!