Skip to content

Conversation

joeyballentine
Copy link
Contributor

@joeyballentine joeyballentine commented Nov 21, 2024

Fix flac scanning when no album art present

Description

If existing flac files don't have images attached to them, spotdl crashes. This fixes that.

Related Issue

Fixes #2237

Motivation and Context

Fixes a bug

How Has This Been Tested?

I used it, and it fixes the bug

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@joeyballentine joeyballentine changed the title Fix flac scanning when no picture metadata present Fix flac scanning when no album art present Nov 21, 2024
@Silverarmor Silverarmor changed the base branch from master to dev November 21, 2024 05:59
@Silverarmor Silverarmor self-requested a review November 21, 2024 06:00
Copy link
Member

@Silverarmor Silverarmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with edit

@Silverarmor Silverarmor merged commit c5449f3 into spotDL:dev Nov 21, 2024
11 checks passed
@joeyballentine joeyballentine deleted the fix-flac-scan branch November 21, 2024 06:18
@Silverarmor
Copy link
Member

will be included in next release of spotDL.

In the interim install from dev
pip install --force -U https://codeload.github.com/spotDL/spotify-downloader/zip/dev

Silverarmor added a commit that referenced this pull request Jan 16, 2025
Fix flac scanning when no album art present #2238 @joeyballentine
Fix m3u file creation, with correct metadata generation #2258
@Silverarmor

Various documentation changes & updates @Silverarmor 

Bump yt-dlp to 2025.1.15 to attempt to alleviate 403 Forbidden errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flacs without album art crash spotdl
2 participants