Enhance Mock()/Stub() signature #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent "Cannot assign 'Object' to 'MyClassToMock'" warning in Idea.
|
👍 |
|
seems good |
|
@robfletcher @leonard84 @sbglasius Any chance to get my little change merged? |
|
+1 on the merge |
|
Interesting I didn't know that you could do that without a either a |
leonard84
added a commit
that referenced
this pull request
Feb 2, 2016
Enhance Mock()/Stub()/Spy() signature to support generic return types
szpak
added a commit
to szpak/spock
that referenced
this pull request
Dec 23, 2017
szpak
added a commit
to szpak/spock
that referenced
this pull request
Dec 23, 2017
szpak
added a commit
to szpak/spock
that referenced
this pull request
Dec 23, 2017
leonard84
pushed a commit
that referenced
this pull request
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change to prevent "Cannot assign 'Object' to 'MyClassToMock'" warning in Idea when the following construction is used:
Spock infers stub/mock type from left-hand side anyway, so it is only a better syntax to express it (like already used for example in
thrown()). This change should not break existing code.Maybe there was some (unknown for me reason) to use just Object and in that case please let me know.