Split gcsfs and sftpfs into separate modules #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
330f94c to
8d0699c
Compare
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
8d0699c to
2af1925
Compare
|
I think this is a great idea. |
bep
approved these changes
Mar 15, 2025
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
|
Y'all move fast. I think this is a brilliant idea. Something we couldn't have easily done without modules, but now with modules, it's a no brainer to do this. |
messikiller
pushed a commit
to messikiller/afero
that referenced
this pull request
Apr 8, 2025
Split gcsfs and sftpfs into separate modules
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the library into three modules:
This change is modeled after a similar, recent change in Viper to reduce dependencies.
@bep @spf13 let me know what you think.
Todo