Remove LSIF support from src-cli #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nversion-from-src-cli
varungandhi-src
approved these changes
Feb 21, 2025
Comment on lines
-65
to
-74
| // Make 'upload' available under 'src lsif' for backwards compatibility. | ||
| lsifCommands = append(lsifCommands, &command{ | ||
| flagSet: codeintelUploadFlagSet, | ||
| handler: handleCodeIntelUpload, | ||
| usageFunc: func() { | ||
| fmt.Fprintf(flag.CommandLine.Output(), "Usage of 'src lsif %s':\n", codeintelUploadFlagSet.Name()) | ||
| codeintelUploadFlagSet.PrintDefaults() | ||
| fmt.Println(usage) | ||
| }, | ||
| }) |
There was a problem hiding this comment.
You'll need to look into how src-cli docs are generated for the docs.sourcegraph.com page and regenerate those.
I found multiple copies of the file, one in the monorepo and one in the docs repo.
Not sure which is the source of truth.
trly
pushed a commit
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also uses streaming parser to infer metdata about index, to avoid loading the whole thing in memory
Test plan