forked from mozilla-services/pkcs7
-
Notifications
You must be signed in to change notification settings - Fork 14
Add support for custom hash calculation function, allowing content streaming #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hslatman
merged 6 commits into
smallstep:main
from
idangutman-ms:idangutman/hash_calc_func_support
Feb 11, 2025
Merged
Add support for custom hash calculation function, allowing content streaming #41
hslatman
merged 6 commits into
smallstep:main
from
idangutman-ms:idangutman/hash_calc_func_support
Feb 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hslatman
reviewed
Feb 5, 2025
hslatman
reviewed
Feb 6, 2025
hslatman
reviewed
Feb 6, 2025
idangutman-ms
commented
Feb 6, 2025
hslatman
approved these changes
Feb 6, 2025
hslatman
added a commit
that referenced
this pull request
Feb 10, 2025
Original work done by idangutman-ms in #41.
Thanks for your contribution, @idangutman-ms 😄 |
This was referenced Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of feature:
Hash calculation function support
Pain or issue this feature alleviates:
This change provides the ability to add a custom function for calculating the content hash.
This is useful for calculating the hash of the content as it is being streamed, instead of requiring the entire content to be loaded into memory, and is necessary for calculating hashes on large files without excessive memory usage.
Why is this important to the project (if not answered above):
Is there documentation on how to use this feature? If so, where?
Example for usage can be seen in test file, where instead of setting
p7.Content
, we use thep7.HashCalc
(settingContent
is optional when usingHashCalc
):In what environments or workflows is this feature supported?
In what environments or workflows is this feature explicitly NOT supported (if any)?
Supporting links/other PRs/issues:
💔Thank you!