Skip to content

[ENH] Adding MLPClassifier #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 26, 2022
Merged

[ENH] Adding MLPClassifier #3232

merged 6 commits into from
Aug 26, 2022

Conversation

AurumnPegasus
Copy link
Contributor

Reference Issues/PRs

Fixes #3192

What does this implement/fix? Explain your changes.

Migrating MLPClassifier from sktime-dl to sktime

PR checklist

For all contributions
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.
For new estimators
  • I've added the estimator to the online documentation.
  • I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@AurumnPegasus
Copy link
Contributor Author

Reminder: Need to change documentation of MLPNetwork

@fkiraly
Copy link
Collaborator

fkiraly commented Aug 19, 2022

if you think it´s ready, kindly turn it to "ready to review"

fkiraly
fkiraly reviewed Aug 19, 2022
View reviewed changes
fkiraly
fkiraly reviewed Aug 19, 2022
View reviewed changes
@AurumnPegasus AurumnPegasus marked this pull request as ready for review August 22, 2022 13:36
@AurumnPegasus AurumnPegasus mentioned this pull request Aug 22, 2022
Open
@AurumnPegasus
Copy link
Contributor Author

Hey @fkiraly ,
The error seems to be a spordiac one as originally reported by you in #2467
Tagging you since resolving this would let me merge the other pending classifiers as well.

fkiraly
fkiraly approved these changes Aug 26, 2022
View reviewed changes
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@fkiraly fkiraly merged commit 33e8f3b into sktime:main Aug 26, 2022
@fkiraly fkiraly mentioned this pull request Aug 26, 2022
Merged
@AurumnPegasus AurumnPegasus mentioned this pull request Aug 26, 2022
Open
27 tasks
fkiraly added a commit that referenced this pull request Aug 26, 2022
@fkiraly
[BUG] fixes missing super.__init__ call in MLPNetwork (#3350)
ddc9440 
Fixes a bug that was introduced to main in #3232.

The tests passed before merge, but the branch was not up to date, missing some newer tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkiraly fkiraly fkiraly approved these changes

@aiwalter aiwalter Awaiting requested review from aiwalter

Assignees

@fkiraly fkiraly

@AurumnPegasus AurumnPegasus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] Adding MLP DL model for classification
2 participants
@AurumnPegasus @fkiraly