Skip to content

Ensures '--len' does not crash or hang #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2020
Merged

Ensures '--len' does not crash or hang #28

merged 1 commit into from
Oct 26, 2020

Conversation

poliorcetics
Copy link
Contributor

@poliorcetics poliorcetics commented Oct 25, 2020 •
edited
Loading

Fixes #24.
Fixes #22.

#24 is essentially a duplicates of #22, the root cause is the ordering of the checks inside the is_stdin function.

I also simplified some parts of ìs_stdin.

@poliorcetics
Ensures '--len' does not crash or hang
b395deb 
Fixes #24.

I also simplified some parts of `ìs_stdin`.
@poliorcetics poliorcetics mentioned this pull request Oct 25, 2020
Closed
@sitkevij sitkevij changed the base branch from master to develop October 26, 2020 15:16
@sitkevij
Copy link
Owner

pointing PR #28 to develop branch for integration testing.

@sitkevij sitkevij merged commit ee50c6b into sitkevij:develop Oct 26, 2020
@sitkevij sitkevij mentioned this pull request Oct 26, 2020
Merged
@poliorcetics poliorcetics deleted the fix-len-crash branch October 29, 2020 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--len argument causes hx to hang -ar flags do not seem to work if they come before the filename.
2 participants
@poliorcetics @sitkevij