Skip to content

Miniscript validity and Script decoding checks #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2021
Merged

Miniscript validity and Script decoding checks #72

merged 2 commits into from
Sep 28, 2021

Conversation

darosior
Copy link
Contributor

@darosior darosior commented Sep 26, 2021 •
edited
Loading

This makes Miniscripts which script is invalid by standradness invalid and check nodes are valid when decoding from Script.

@darosior darosior force-pushed the parsing_checks branch 4 times, most recently from dc402a9 to fdb032b Compare September 27, 2021 12:34
@darosior darosior marked this pull request as ready for review September 27, 2021 12:41
@darosior darosior mentioned this pull request Sep 27, 2021
Merged
@darosior darosior changed the title Script parsing checks Miniscript validity and Script decoding checks Sep 27, 2021
@darosior darosior mentioned this pull request Sep 27, 2021
Merged
@darosior
Copy link
Contributor Author

Added a note in the index.html about nonstandard Script size being invalid.

sipa
sipa reviewed Sep 28, 2021
View reviewed changes
sipa
sipa reviewed Sep 28, 2021
View reviewed changes
sipa
sipa reviewed Sep 28, 2021
View reviewed changes
@darosior
Copy link
Contributor Author

Addressed the comment, and reorganized the diff which i again got mixed up between the commits and the two repos.

@sipa
Copy link
Owner

sipa commented Sep 28, 2021

ACK c1ecd13

@sipa sipa merged commit 36e6446 into sipa:master Sep 28, 2021
@sanket1729
Copy link
Contributor

POst merge ACK c1ecd13

@darosior darosior deleted the parsing_checks branch September 28, 2021 18:08
sipa added a commit that referenced this pull request Sep 29, 2021
@sipa
Merge #75: Miniscript safety
385c98e 
253172e compiler: use IsSane in place of ad hoc sanity checks (Antoine Poinsot)
e27282e miniscript: only check "s" at top level for IsSane, rename IsSafe -> IsSane (Antoine Poinsot)
fa2fa68 miniscript: IsSafe() implies IsValid(), separate IsSafe() and IsSafeTopLevel() (Antoine Poinsot)

Pull request description:

  Based on #72 this separates `IsSafe` and `IsSafeTopLevel` as suggested in #41 (comment) .

ACKs for top commit:
  sipa:
    ACK 253172e

Tree-SHA512: 5f1bbff0e9092e13f1df6a9166dc8738e694cb6b78b07bc50ec0968ecc07a74e8f73405ba4932753c70cb58a3ff9c62de1b7fe8468f4a4c6295541de557c4457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sipa sipa sipa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darosior @sipa @sanket1729