Avoid heap out-of-bounds read in Node::CalcOps (test case: OP_0 OP_2 OP_EQUAL) and assertion failure in ComputeType (test case: OP_0 OP_0 OP_EQUAL) #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unds read in case of k >= sats.size()
|
@sipa Looks good? :) |
|
@sanket1729 Want to have a look? This may interact with #39 . |
|
I think we can merge this as it is and then I can address issue for changing thresholds ( |
|
Now that 1.5 years have passed I've largely forgotten the context of these changes, so I think it would be better for someone else with fresh knowledge of the code base to take over the task of fixing this issue :) Anyone who want to take over this PR if I close it as "up for grabs"? |
|
The work on addressing this issue has been taken over at @sanket1729 in PR #57. Closing this PR. Thanks @sanket1729! |
sipa
added a commit
that referenced
this pull request
Aug 19, 2021
… OP_0 OP_2 OP_EQUAL) and assertion failure in ComputeType (test case: OP_0 OP_0 OP_EQUAL) a47dcc6 Add assertions: Raise assertion failure instead of doing an out-of-bounds read in case of k > sats.size() (sanket1729) 0d43166 Avoid heap out-of-bounds read in Node::CalcOps (test case: OP_0 OP_2 OP_EQUAL) and assertion failure in ComputeType (test case: OP_0 OP_0 OP_EQUAL) (practicalswift) Pull request description: Closes #12. Closes #13. Supercedes #18 ACKs for top commit: sipa: utACK a47dcc6 darosior: ACK a47dcc6 meshcollider: utACK a47dcc6 Tree-SHA512: 85ea2f791e5b6a2c80dee567895dffe386f5fe4973b97dd7102b91f2e500bf9087dcbaeafe9e635abc02b27a97918bc69ae38b6769d93f2b3a071eb976a606c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid heap out-of-bounds read in
Node::CalcOps(test case:OP_0 OP_2 OP_EQUAL) and assertion failure inComputeType(test case:OP_0 OP_0 OP_EQUAL).