fix: set schema name for migrations based on searchPath in PostgresBackend #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes PostgreSQL migrations to work correctly with custom schemas by ensuring the schema exists before running migrations and setting the schema name for migration tracking.
- Adds schema creation logic to PostgresBackend's migrate method
- Extracts schema name from searchPath configuration and applies it to Knex migrations
- Creates comprehensive test coverage for schema-based operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/backends/postgres/src/postgres-backend.ts | Implements schema extraction from searchPath, adds ensureSchemaExists method, and overrides migrate to create schema before running migrations |
| packages/backends/postgres/test/with-schema.test.ts | Adds test coverage for PostgresBackend with custom schema configuration |
sidequest-release bot
pushed a commit
that referenced
this pull request
Aug 11, 2025
## [1.4.3](v1.4.2...v1.4.3) (2025-08-11) ### Bug Fixes * set schema name for migrations based on searchPath in PostgresBackend ([#67](#67)) ([686afa5](686afa5))
|
🎉 This PR is included in version 1.4.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for Pull Requests
yarn test:allandyarn test:integration)Summary of Changes
Closes #62