feat: relative path on script resolution #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for Pull Requests
yarn test:all
)Summary of Changes
This PR allows running scripts based on relative path.
This allows the user to run scripts in machines with different dir trees, as long as the files use the same relative path to the
node_modules
that import it.For example, if the user enqueues a job
/path/to/jobs/myjob.js
using/path/to/main/mainscript.js
, and Sidequest is installed in/path/to/node_modules
, then any machine that has hasjobs/myjob.js
relative tonode_modules
where Sidequest is installed can run the script.This effectively removes the limitation of having exactly the same dir tree (absolute path).
Closes #52