Skip to content

Conversation

GiovaniGuizzo
Copy link
Contributor

Checklist for Pull Requests

  • All tests pass (yarn test:all)
  • Code follows the style guide and passes lint checks
  • Documentation is updated (README, docs, etc)
  • Linked to corresponding issue, if applicable

Summary of Changes

This PR allows running scripts based on relative path.
This allows the user to run scripts in machines with different dir trees, as long as the files use the same relative path to the node_modules that import it.

For example, if the user enqueues a job /path/to/jobs/myjob.js using /path/to/main/mainscript.js, and Sidequest is installed in /path/to/node_modules, then any machine that has has jobs/myjob.js relative to node_modules where Sidequest is installed can run the script.

This effectively removes the limitation of having exactly the same dir tree (absolute path).

Closes #52

@GiovaniGuizzo GiovaniGuizzo requested a review from merencia as a code owner August 6, 2025 19:42
@GiovaniGuizzo GiovaniGuizzo merged commit 65cf83a into master Aug 7, 2025
2 checks passed
@GiovaniGuizzo GiovaniGuizzo deleted the feat/relative-path branch August 7, 2025 12:51
sidequest-release bot pushed a commit that referenced this pull request Aug 7, 2025
# [1.4.0](v1.3.0...v1.4.0) (2025-08-07)

### Features

* relative path on script resolution ([#58](#58)) ([65cf83a](65cf83a))
@sidequest-release
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to relative path on script resolution
2 participants