Skip to content
This repository was archived by the owner on Mar 20, 2024. It is now read-only.

Conversation

frewsxcv
Copy link

Rebase of #107

Review on Reviewable

@Manishearth
Copy link
Member

I'd rather not diverge from homu/homu too much; this PR will make every uplift need merge conflict fixing.

(Also, I'd rather not switch to servo/homu unless we really need to)

@frewsxcv
Copy link
Author

(Also, I'd rather not switch to servo/homu unless we really need to)

Homu seems to break every day. How confident are you that your SQLite changes today fixes that?

@frewsxcv
Copy link
Author

(Also, I'd rather not switch to servo/homu unless we really need to)

Also, why?

@Manishearth
Copy link
Member

Homu seems to break every day.

AFAICT that was one bit of brokenness introduced due to homu being restarted at the wrong time, which sort of stayed around mucking up the internals and making it keep two pending PRs at all times.

How does switching to servo/homu fix it, even if it was a code issue?

I don't mind switching to get upstream patches faster, I'd rather avoid diverging though.

@Manishearth
Copy link
Member

Also, why?

Just extra work to keep it up to date. I don't like forking unless there's a need; code formatting isn't a need 😄

@frewsxcv
Copy link
Author

How does switching to servo/homu fix it, even if it was a code issue?

I was planning to maintain this repository. I wanted to start by incorporating a sane linter.

@frewsxcv
Copy link
Author

So, a month later. Have any thoughts about this now?

@Manishearth
Copy link
Member

Update master to homu master first, but sure, merge this!

@frewsxcv
Copy link
Author

From what I can tell, servo/homu is up-to-date with barosl/homu, if that's what you're asking

@frewsxcv
Copy link
Author

Also, should we get homu set up here in servo/homu? 😛

@Manishearth
Copy link
Member

r+

frewsxcv added a commit that referenced this pull request Jan 12, 2016
Incorporate 'flake8' linting via Travis CI
@frewsxcv frewsxcv merged commit 625a68a into servo:master Jan 12, 2016
kennytm added a commit to kennytm/homu that referenced this pull request May 31, 2018
Stop truncating the commit hash.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants