Skip to content

Add zstd support #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2024
Merged

Add zstd support #1866

merged 1 commit into from
Apr 15, 2024

Conversation

paolobarbolini
Copy link
Contributor

@paolobarbolini paolobarbolini commented Jun 3, 2023 •
edited
Loading

This PR has been recreated after I accidentally deleted my fork for #1464

Closes #1463

@paolobarbolini paolobarbolini mentioned this pull request Jun 3, 2023
Closed
@ozgrakkurt
Copy link

This would be very useful indeed

@tafia
Copy link
Contributor

tafia commented Nov 29, 2023

Is there any news / blocking point?

@paolobarbolini
Copy link
Contributor Author

Is there any news / blocking point?

No blockers on my part. I too wish we could get feedback on this PR, especially considering that lately there has been some progress with zstd on the web https://caniuse.com/zstd

@paolobarbolini
Copy link
Contributor Author

It looks like Chromium may be close to shipping it 1. I'd be happy to rebase after the hyper v1 upgrade @seanmonstar.

Footnotes

  1. https://chromestatus.com/feature/6186023867908096 ↩

@seanmonstar
Copy link
Owner

Thanks for pushing on this for so long. I remember looking a while ago, and it seemed to be unhappy on Windows. Assuming it works fine now, I'd be happy to merge.

@paolobarbolini
Copy link
Contributor Author

Yeah zstd had a Windows issue some time ago, it's been fixed upstream. I think this is ready for merging.

@seanmonstar seanmonstar merged commit 1073881 into seanmonstar:master Apr 15, 2024
@seanmonstar
Copy link
Owner

Thanks again! I delayed merging a little bit just in case there was major problems with v0.12 that I'd need to revert or handle. But seems like its pretty smooth now. So this will go out in the next release.

@deedy5 deedy5 mentioned this pull request May 13, 2024
Closed
@0x676e67 0x676e67 mentioned this pull request May 14, 2024
Merged
Nutomic pushed a commit to Nutomic/reqwest that referenced this pull request Nov 7, 2024
@paolobarbolini @Nutomic
feat: add zstd support (seanmonstar#1866)
0eb7521 
Closes seanmonstar#1463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Content-Encoding: zstd
4 participants
@paolobarbolini @ozgrakkurt @tafia @seanmonstar