use go embed for templates #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 12, 2021
houndci-bot
reviewed
Nov 12, 2021
ccojocar
approved these changes
Nov 15, 2021
fnaranjo-vmw
added a commit
to cloudfoundry/persi-ci
that referenced
this pull request
Nov 25, 2021
Latest changes in gosec don't work with go <1.16: securego/gosec#725 We need more careful testing before doing such version bump
Cryogenics-CI
pushed a commit
to cloudfoundry/persi-ci
that referenced
this pull request
Nov 25, 2021
Latest changes in gosec don't work with go <1.16: securego/gosec#725 We need more careful testing before doing such version bump
fnaranjo-vmw
added a commit
to cloudfoundry/persi-ci
that referenced
this pull request
Nov 25, 2021
Latest changes in gosec don't work with go <1.16: securego/gosec#725 We need more careful testing before doing such version bump
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since go 1.15 is now phased out we could reactivate the changes from #625
Use go embed feature to make template maintenance easier.