-
Notifications
You must be signed in to change notification settings - Fork 17
Closed
Labels
enhancementNew feature or requestNew feature or requestgoPull requests that update Go codePull requests that update Go codegood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Context: feedback and feature request captured thanks to this blog post, thanks Artem!
In order to better support the management and assignment of Namespace
on Manifests generated or patched by score-k8s generate
, we need to add the --namespace
and --generate-namespace
flags for score-k8s generate
.
Like helm install|upgrade
works.
--namespace
(optional) will set themetadata.namespace
field if supplied--generate-namespace
(optional) will actually add a defaultNamespace
manifest in the generatedmanifests.yaml
,--namespace
will be required in this case.
We also need to think about how this --namespace
value is passed through/to the provisioners
and patch-templates
for them to set the value if supplied.
Note: if someone wants to patch the generated Namespace
, they will be able to use a patch-templates
to inject annotations
, labels
, etc.
Implementation details:
- Feat: Add
--namespace
and--generate-namespace
flags forscore-k8s generate
#176 -
namespace
passed through the--patch-templates
#183 - Support
--namespace
withservice-account
withscore-k8s
0.5.2
community-patchers#17 - namespace-pss-restricted community-patchers#18
- CLI:
--namespace
and--generate-namespace
docs#191 - Support of
--namespace
for provisioners #187 - Support
score-k8s
's--namespace
community-provisioners#40 - Take into account
.Namespace
in default provisioners #190
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgoPull requests that update Go codePull requests that update Go codegood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Type
Projects
Status
Done