Skip to content

namespace passed through the --patch-templates #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2025
Merged

namespace passed through the --patch-templates #183

merged 2 commits into from
Jun 13, 2025

Conversation

Yadavanurag13
Copy link
Contributor

Description

What does this PR do?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

@Yadavanurag13
namespcase passed through the --patch-template
5d3e3fe 
Signed-off-by: Anurag Yadav <yadavanurag1310@gmail.com>
@Yadavanurag13
Added unit test
d46e8e8 
Signed-off-by: Anurag Yadav <yadavanurag1310@gmail.com>
@Yadavanurag13 Yadavanurag13 changed the title [WIP] Namespcase passed through the --patch-template Namespcase passed through the --patch-template Jun 13, 2025
@Yadavanurag13
Copy link
Contributor Author

@mathieu-benoit I have made changes that were stated in #172.

Can you please review it and let me know if any modifications are required.

@mathieu-benoit mathieu-benoit changed the title Namespcase passed through the --patch-template namespace passed through the --patch-template Jun 13, 2025
@mathieu-benoit mathieu-benoit changed the title namespace passed through the --patch-template namespace passed through the --patch-templates Jun 13, 2025
@mathieu-benoit mathieu-benoit mentioned this pull request Jun 13, 2025
Closed
8 tasks
mathieu-benoit
mathieu-benoit approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's it! Thanks, @Yadavanurag13!

@mathieu-benoit mathieu-benoit merged commit 83e4e3a into score-spec:main Jun 13, 2025
6 checks passed
@mathieu-benoit mathieu-benoit mentioned this pull request Jun 13, 2025
Merged
@mathieu-benoit
Copy link
Contributor

JFYI: tested and integrated in there too score-spec/community-patchers#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieu-benoit mathieu-benoit mathieu-benoit approved these changes

Assignees

@Yadavanurag13 Yadavanurag13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yadavanurag13 @mathieu-benoit