.github/workflows/ci-sage.yml: Update after SageMath's move to GitHub #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e248a4b to
1d54896
Compare
1d54896 to
b93df4e
Compare
|
Thanks for the fixes. I think that the patches are old - or at least they should be incorporated. If not, I should include them here. How can I remove multiple patches in the "REMOVE_PATCHES" line in the yml file? |
Everything in the quotes just becomes part of a command-line of |
Not sure if I sent all of them to you via PR. The patches are at https://github.com/sagemath/sage/tree/develop/build/pkgs/scip_sdp/patches |
|
Thanks. I will check the rpath patch. |
|
I check all the patches and they should be included. The current errors all seem to happen because |
5 tasks
|
Right, |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 1, 2023
sagemathgh-35786: onetbb: Upgrade to 2021.9.0 + GCC13 patch <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> To fix build on fedora-39-minimal, archlinux-latest-{minimal,standard}, opensuse-tumbleweed-minimal - as seen in https://github.com/scipopt/SCIP-SDP/actions/runs/5203680653 (scipopt/SCIP-SDP#6) Tests at https://github.com/mkoeppe/SCIP-SDP/actions/runs/5298512526 <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> Part of: - sagemath#35092 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> - Depends on sagemath#35785 (merged here) <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35786 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to sagemath/sage
that referenced
this pull request
Oct 8, 2023
gh-35786: onetbb: Upgrade to 2021.9.0 + GCC13 patch <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> To fix build on fedora-39-minimal, archlinux-latest-{minimal,standard}, opensuse-tumbleweed-minimal - as seen in https://github.com/scipopt/SCIP-SDP/actions/runs/5203680653 (scipopt/SCIP-SDP#6) Tests at https://github.com/mkoeppe/SCIP-SDP/actions/runs/5298512526 <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> Part of: - #35092 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> - Depends on #35785 (merged here) <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35786 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4 (comment)
Manually triggered test run: https://github.com/mkoeppe/SCIP-SDP/actions/runs/5194662758
(the tests now fail because another one of our patches is incompatible with the changes in SCIP-SDP - see https://github.com/mkoeppe/SCIP-SDP/actions/runs/5194662758/jobs/9366583370#step:10:5123 .)