Skip to content

Conversation

matzf
Copy link
Contributor

@matzf matzf commented Jan 29, 2021

The /run/shm/sciond/ directory used to contain the sciond unix sockets.
These sockets have been replaced by TCP sockets quite some time ago,
in #3652.

Remove the no longer necessary creation and cleanup of this directory
from the scion.sh script.


This change is Reviewable

@matzf matzf force-pushed the cleanup-scion-sh-sciond branch 2 times, most recently from f8ca663 to 52fc9b0 Compare January 29, 2021 12:22
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla
Copy link
Contributor

oncilla commented Feb 2, 2021

/rebase

The /run/shm/sciond/ directory used to contain the sciond unix sockets.
These sockets have been replaced by TCP sockets quite some time ago,
in scionproto#3652.

Remove the no longer necessary creation and cleanup of this directory
from the scion.sh script.
@github-actions github-actions bot force-pushed the cleanup-scion-sh-sciond branch from 23fd681 to b41e6cb Compare February 2, 2021 15:32
@oncilla oncilla closed this in 9fa755e Feb 2, 2021
@matzf matzf deleted the cleanup-scion-sh-sciond branch February 2, 2021 19:20
matzf added a commit to netsec-ethz/scion that referenced this pull request Feb 5, 2021
The /run/shm/sciond/ directory used to contain the sciond unix sockets.
These sockets have been replaced by TCP sockets quite some time ago,
in scionproto#3652.

Remove the no longer necessary creation and cleanup of this directory
from the scion.sh script.

Closes scionproto#3971

GitOrigin-RevId: 07d7215f45eebca5c4f9499213b8a2d342d802f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants