Skip to content

toml: use snake_case remove unused properties #3684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

toml: use snake_case remove unused properties #3684

merged 1 commit into from
Mar 10, 2020

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Mar 10, 2020 •
edited by kormat
Loading

Remove all currently unused configuration options.
Change all config options to snake_case.

Fixes #2412

This change is Reviewable

@lukedirtwalker
toml: use snake_case remove unused properties
0f02329 
Remove all currently unused configuration options.
Change all config options to snake_case.

Fixes scionproto#2412
@lukedirtwalker lukedirtwalker requested a review from oncilla March 10, 2020 08:02
@lukedirtwalker lukedirtwalker added the i/breaking change PR that breaks forwards or backwards compatibility label Mar 10, 2020
oncilla
oncilla approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 57 of 57 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 5a03123 into scionproto:master Mar 10, 2020
@lukedirtwalker lukedirtwalker deleted the pubToml branch March 10, 2020 09:14
matzf added a commit to netsec-ethz/scionlab that referenced this pull request Mar 10, 2020
@matzf
Update toml keys after scionproto/scion#3684
1814a70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oncilla oncilla oncilla approved these changes

Assignees
No one assigned
Labels
i/breaking change PR that breaks forwards or backwards compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toml: fix casing in config files
2 participants
@lukedirtwalker @oncilla