Skip to content

braccept: expired revocation on interface not owned #3664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 14, 2020
Merged

braccept: expired revocation on interface not owned #3664

merged 3 commits into from
Feb 14, 2020

Conversation

sgmonroy
Copy link
Contributor

@sgmonroy sgmonroy commented Feb 13, 2020 •
edited by kormat
Loading

This change is Reviewable

@sgmonroy
braccept: expired revocation to not owned interface
9355951
@sgmonroy
border: fix panic on expired revocation
6c0a2aa 
Fix the panic caused when an interface owned by another BR in the AS had
an expired revocation.

The intial issue was caught because control service stop running after
the interface was revoked.

2020-02-13 14:53:32.276664+0000 [INFO] IFState: intf deactivated ifid=181
2020-02-13 14:53:32.527054+0000 [CRIT] Panic msg="runtime error: invalid
memory address or nil pointer dereference" stack=
>  goroutine 124 [running]:
>  runtime/debug.Stack(0xc000f3ef30, 0xcb8b40, 0x1564c80)
>       GOROOT/src/runtime/debug/stack.go:24 +0x9d
>  github.com/scionproto/scion/go/lib/log.LogPanicAndExit()
>       go/lib/log/log.go:151 +0x6e
>  panic(0xcb8b40, 0x1564c80)
>       GOROOT/src/runtime/panic.go:679 +0x1b2
> github.com/scionproto/scion/go/border/rpkt.(*RtrPkt).validateLocalIF(0xc00014fc00,
        0xc000f34e50, 0x10, 0x10)
>       go/border/rpkt/path.go:127 +0x463
> github.com/scionproto/scion/go/border/rpkt.(*RtrPkt).forwardFromExternal(
        0xc00014fc00, 0xc0000be080, 0x5e4562ec, 0xc000f48bc0)
>       go/border/rpkt/route.go:135 +0x329
> github.com/scionproto/scion/go/border/rpkt.(*RtrPkt).forward(0xc00014fc00,
        0x8, 0x8, 0xcb51c0)
>       go/border/rpkt/route.go:93 +0x151
> github.com/scionproto/scion/go/border/rpkt.(*RtrPkt).Route(0xc00014fc00,
        0x0, 0x0)
>       go/border/rpkt/route.go:43 +0x87
>  main.(*Router).processPacket(0xc0001482c0, 0xc00014fc00)
>       go/border/router.go:172 +0x76f
>  main.(*Router).handleSock(0xc0001482c0, 0xc0000fd3b0,
        0xc0001e2900, 0xc0001e29c0)
>       go/border/router.go:102 +0x193
> github.com/scionproto/scion/go/border/rctx.(*Sock).Start.func2(0xc0000fd3b0)
>       go/border/rctx/io.go:108 +0x67
>  created by github.com/scionproto/scion/go/border/rctx.(*Sock).Start
>       go/border/rctx/io.go:106 +0x230
2020-02-13 14:53:32.527232+0000 [CRIT] =====================>
Service panicked!
@sgmonroy
set valid revocation and wait until it expires
4005b27
oncilla
oncilla approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sgmonroy sgmonroy merged commit b4caf0e into scionproto:master Feb 14, 2020
@sgmonroy sgmonroy deleted the br-acceptance-rev-panic branch February 14, 2020 09:51
stygerma pushed a commit to stygerma/scion that referenced this pull request Mar 26, 2020
@sgmonroy @stygerma
braccept: expired revocation on interface not owned (scionproto#3664)
418cdbc 
Fix the panic caused when an interface owned by another BR in the AS had
an expired revocation.

The intial issue was caught because control service stop running after
the interface was revoked.

2020-02-13 14:53:32.276664+0000 [INFO] IFState: intf deactivated ifid=181
2020-02-13 14:53:32.527054+0000 [CRIT] Panic msg="runtime error: invalid
memory address or nil pointer dereference" stack=
>  goroutine 124 [running]:
>  runtime/debug.Stack(0xc000f3ef30, 0xcb8b40, 0x1564c80)
>       GOROOT/src/runtime/debug/stack.go:24 +0x9d
>  github.com/scionproto/scion/go/lib/log.LogPanicAndExit()
>       go/lib/log/log.go:151 +0x6e
>  panic(0xcb8b40, 0x1564c80)
>       GOROOT/src/runtime/panic.go:679 +0x1b2
> github.com/scionproto/scion/go/border/rpkt.(*RtrPkt).validateLocalIF(0xc00014fc00,
        0xc000f34e50, 0x10, 0x10)
>       go/border/rpkt/path.go:127 +0x463
> github.com/scionproto/scion/go/border/rpkt.(*RtrPkt).forwardFromExternal(
        0xc00014fc00, 0xc0000be080, 0x5e4562ec, 0xc000f48bc0)
>       go/border/rpkt/route.go:135 +0x329
> github.com/scionproto/scion/go/border/rpkt.(*RtrPkt).forward(0xc00014fc00,
        0x8, 0x8, 0xcb51c0)
>       go/border/rpkt/route.go:93 +0x151
> github.com/scionproto/scion/go/border/rpkt.(*RtrPkt).Route(0xc00014fc00,
        0x0, 0x0)
>       go/border/rpkt/route.go:43 +0x87
>  main.(*Router).processPacket(0xc0001482c0, 0xc00014fc00)
>       go/border/router.go:172 +0x76f
>  main.(*Router).handleSock(0xc0001482c0, 0xc0000fd3b0,
        0xc0001e2900, 0xc0001e29c0)
>       go/border/router.go:102 +0x193
> github.com/scionproto/scion/go/border/rctx.(*Sock).Start.func2(0xc0000fd3b0)
>       go/border/rctx/io.go:108 +0x67
>  created by github.com/scionproto/scion/go/border/rctx.(*Sock).Start
>       go/border/rctx/io.go:106 +0x230
2020-02-13 14:53:32.527232+0000 [CRIT] =====================>
Service panicked!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oncilla oncilla oncilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgmonroy @oncilla